Skip to content

Conversation

@sleepypioneer
Copy link
Contributor

@sleepypioneer sleepypioneer commented Jul 28, 2023

  • No issue for this change, was noticed while running through the onboarding docs
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@noatamir @phofl PyLadies Hamburg Sprint

@sleepypioneer sleepypioneer requested a review from noatamir as a code owner July 28, 2023 18:03
You can find the detailed documentation on how rendering the documentation with
Sphinx works in the :ref:`contributing.howto-build-docs` section. To build the full
docs you need to run the following command in the docs directory::
docs you need to run the following command in the :ref:`/doc` directory::
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is wrong sorry, let me change it :)

@noatamir noatamir added the Sprints Sprint Pull Requests label Jul 28, 2023
@noatamir
Copy link
Member

/preview

@github-actions
Copy link
Contributor

No preview found for PR #54292. Did the docs build complete?

add backticks for directory reference

Co-authored-by: Noa Tamir <6564007+noatamir@users.noreply.github.com>
@sleepypioneer
Copy link
Contributor Author

No preview found for PR #54292. Did the docs build complete?

@noatamir I am not sure what this means, locally (in gitpod) I could build and view the docs)

@noatamir
Copy link
Member

/preview

@github-actions
Copy link
Contributor

No preview found for PR #54292. Did the docs build complete?

@noatamir
Copy link
Member

trying the auto-preview again. If it doesn't work a screenshot would be fine for me

@noatamir noatamir added the Docs label Jul 30, 2023
@sleepypioneer
Copy link
Contributor Author

Screen shots for changes:

Screenshot 2023-07-30 at 18 05 04
Screenshot 2023-07-30 at 18 06 25

@phofl
Copy link
Member

phofl commented Jul 30, 2023

/preview

@github-actions
Copy link
Contributor

No preview found for PR #54292. Did the docs build complete?

@noatamir
Copy link
Member

Thanks @sleepypioneer!

Copy link
Member

@noatamir noatamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sleepypioneer 💐

@noatamir noatamir merged commit 8067a01 into pandas-dev:main Aug 1, 2023
@noatamir noatamir added this to the 2.1 milestone Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Docs Sprints Sprint Pull Requests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants