Skip to content

BUG: Raise clear error when assign is used with non-string column keys #61297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 174 commits into from
Closed

BUG: Raise clear error when assign is used with non-string column keys #61297

wants to merge 174 commits into from

Conversation

AnushaUKumar
Copy link

What does this PR do?

Fixes confusing behavior when .assign() is used with non-string keys like tuples. Python raises a generic TypeError: keywords must be strings, which confuses users.

This PR adds a more helpful message:

assign() only supports string column names. Use df[('C', 'one')] = ... to assign non-string column names like tuples.

Why?

This improves the developer experience and avoids unnecessary debugging time.

How was this fixed?

  • Added __kwargs_dict__ as a keyword-only argument for testing with tuple keys
  • Added validation in assign() for string-only keys
  • Updated existing test for compatibility
  • Added new test: test_assign_with_tuple_column_key_raises_typeerror

Test added

test_assign_with_tuple_column_key_raises_typeerror

meeseeksmachine and others added 30 commits August 12, 2023 21:55
@meeseeksmachine @phofl
Backport PR #54498 on branch 2.1.x (Speed up string inference in mayb…
7f25175 
…e_convert_objects) (#54512)

Backport PR #54498: Speed up string inference in maybe_convert_objects

Co-authored-by: Patrick Hoefler <61934744+phofl@users.noreply.github.com>
@meeseeksmachine @omar-elbaz
Backport PR #54504 on branch 2.1.x (Move Unit Tests for groupby.rolli…
0fb9149 
…ng.corr) (#54513)

Backport PR #54504: Move Unit Tests for groupby.rolling.corr

Co-authored-by: omar-elbaz <114315316+omar-elbaz@users.noreply.github.com>
@meeseeksmachine @lukemanley
Backport PR #54509 on branch 2.1.x (PERF: Dataframe reductions with E…
06e04b0 
…A dtypes) (#54514)

Backport PR #54509: PERF: Dataframe reductions with EA dtypes

Co-authored-by: Luke Manley <lukemanley@gmail.com>
@meeseeksmachine @phofl
Backport PR #54517 on branch 2.1.x (Run CI on 2.1.x) (#54522)
b3f122c 
Backport PR #54517: Run CI on 2.1.x

Co-authored-by: Patrick Hoefler <61934744+phofl@users.noreply.github.com>
@meeseeksmachine @lukemanley @phofl
Backport PR #54515 on branch 2.1.x (ENH: ArrowExtensionArray(duration…
b215522 
…) workarounds for pyarrow versions >= 11.0) (#54524)

Backport PR #54515: ENH: ArrowExtensionArray(duration) workarounds for pyarrow versions >= 11.0

Co-authored-by: Luke Manley <lukemanley@gmail.com>
Co-authored-by: Patrick Hoefler <61934744+phofl@users.noreply.github.com>
@meeseeksmachine @lukemanley
Backport PR #54341 on branch 2.1.x (PERF: axis=1 reductions with EA d…
08edd64 
…types) (#54528)

Backport PR #54341: PERF: axis=1 reductions with EA dtypes

Co-authored-by: Luke Manley <lukemanley@gmail.com>
@meeseeksmachine @phofl
Backport PR #54536 on branch 2.1.x (REF: Move checks to object into a…
723b2c6 
… variable) (#54538)

Backport PR #54536: REF: Move checks to object into a variable

Co-authored-by: Patrick Hoefler <61934744+phofl@users.noreply.github.com>
@meeseeksmachine @phofl
Backport PR #54534 on branch 2.1.x (REF: Move methods that can be sha…
64e4527 
…red with new string dtype) (#54539)

Backport PR #54534: REF: Move methods that can be shared with new string dtype

Co-authored-by: Patrick Hoefler <61934744+phofl@users.noreply.github.com>
@meeseeksmachine @phofl
Backport PR #54537 on branch 2.1.x (REF: Refactor using_pyarrow check…
f59950d 
… for string tests) (#54559)

Backport PR #54537: REF: Refactor using_pyarrow check for string tests

Co-authored-by: Patrick Hoefler <61934744+phofl@users.noreply.github.com>
@meeseeksmachine @lithomas1
Backport PR #54525 on branch 2.1.x (BLD: Fix version script) (#54560)
e69fab9 
Backport PR #54525: BLD: Fix version script

Co-authored-by: Thomas Li <47963215+lithomas1@users.noreply.github.com>
@meeseeksmachine @dependabot
Backport PR #54541 on branch 2.1.x (Bump pypa/cibuildwheel from 2.14.…
91969c6 
…1 to 2.15.0) (#54558)

Backport PR #54541: Bump pypa/cibuildwheel from 2.14.1 to 2.15.0

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@meeseeksmachine @rsm-23
Backport PR #54493 on branch 2.1.x (DOC: updated required dependencie…
4160d69 
…s list) (#54562)

Backport PR #54493: DOC: updated required dependencies list

Co-authored-by: Rajat Subhra Mukherjee <raromukherjee@gmail.com>
@meeseeksmachine @mtsokol
Backport PR #54579 on branch 2.1.x (ENH: Reflect changes from numpy…
4fbe078 
… namespace refactor Part 3) (#54583)

Backport PR #54579: ENH: Reflect changes from `numpy` namespace refactor Part 3

Co-authored-by: Mateusz Sokół <8431159+mtsokol@users.noreply.github.com>
@meeseeksmachine @rhshadrach
Backport PR #54545 on branch 2.1.x (DOC: whatsnew 2.1.0 refinements) (#…
49c2f33 
…54588)

Backport PR #54545: DOC: whatsnew 2.1.0 refinements

Co-authored-by: Richard Shadrach <45562402+rhshadrach@users.noreply.github.com>
@meeseeksmachine @phofl
Backport PR #54535 on branch 2.1.x (REF: Replace "pyarrow" string sto…
005d876 
…rage checks with variable) (#54594)

Backport PR #54535: REF: Replace "pyarrow" string storage checks with variable

Co-authored-by: Patrick Hoefler <61934744+phofl@users.noreply.github.com>
@meeseeksmachine @lukemanley
Backport PR #54574 on branch 2.1.x (ENH: add cummax/cummin/cumprod su…
0335d39 
…pport for arrow dtypes) (#54603)

Backport PR #54574: ENH: add cummax/cummin/cumprod support for arrow dtypes

Co-authored-by: Luke Manley <lukemanley@gmail.com>
@meeseeksmachine @lithomas1
Backport PR #54615 on branch 2.1.x (DOC: Update build instructions in…
802e5ee 
… the README) (#54619)

Backport PR #54615: DOC: Update build instructions in the README

Co-authored-by: Thomas Li <47963215+lithomas1@users.noreply.github.com>
@meeseeksmachine @mroeschke
Backport PR #54587 on branch 2.1.x (CI: Enable MacOS Python Dev tests) (
f7723bb 
#54614)

Backport PR #54587: CI: Enable MacOS Python Dev tests

Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
@meeseeksmachine @phofl
Backport PR #54586 on branch 2.1.x (REF: Refactor conversion of na va…
72282be 
…lue) (#54658)

Backport PR #54586: REF: Refactor conversion of na value

Co-authored-by: Patrick Hoefler <61934744+phofl@users.noreply.github.com>
@meeseeksmachine @jorisvandenbossche
Backport PR #54633 on branch 2.1.x (DEP: remove python-snappy and bro…
dc04d00 
…tli as optional dependencies (no longer used)) (#54637)

Backport PR #54633: DEP: remove python-snappy and brotli as optional dependencies (no longer used)

Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
@meeseeksmachine @phofl
Backport PR #54641 on branch 2.1.x (BUG: getitem indexing wrong axis) (…
23cb250 
…#54669)

Backport PR #54641: BUG: getitem indexing wrong axis

Co-authored-by: Patrick Hoefler <61934744+phofl@users.noreply.github.com>
@meeseeksmachine @phofl
Backport PR #54496 on branch 2.1.x (Fix inference for fixed with nump…
eb36710 
…y strings with arrow string option) (#54672)

Backport PR #54496: Fix inference for fixed with numpy strings with arrow string option

Co-authored-by: Patrick Hoefler <61934744+phofl@users.noreply.github.com>
@meeseeksmachine @mroeschke
Backport PR #54678 on branch 2.1.x (COMPAT: Workaround invalid PyArro…
59a10cc 
…w duration conversion) (#54688)

Backport PR #54678: COMPAT: Workaround invalid PyArrow duration conversion

Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
@meeseeksmachine @phofl
Backport PR #54510 on branch 2.1.x (Speed up StringDtype arrow implem…
8b03024 
…entation for merge) (#54689)

Backport PR #54510: Speed up StringDtype arrow implementation for merge

Co-authored-by: Patrick Hoefler <61934744+phofl@users.noreply.github.com>
@meeseeksmachine @lukemanley
Backport PR #54685 on branch 2.1.x (ENH: support integer bitwise ops …
8c8ddc7 
…in ArrowExtensionArray) (#54691)

Backport PR #54685: ENH: support integer bitwise ops in ArrowExtensionArray

Co-authored-by: Luke Manley <lukemanley@gmail.com>
@meeseeksmachine @phofl
Backport PR #54670 on branch 2.1.x (BUG: drop_duplicates raising for …
6c5e79b 
…boolean arrow dtype with missing values) (#54692)

Backport PR #54670: BUG: drop_duplicates raising for boolean arrow dtype with missing values

Co-authored-by: Patrick Hoefler <61934744+phofl@users.noreply.github.com>
@meeseeksmachine @jbrockmendel
Backport PR #54566 on branch 2.1.x (ENH: support Index.any/all with f…
1dbd792 
…loat, timedelta64 dtypes) (#54693)

Backport PR #54566: ENH: support Index.any/all with float, timedelta64 dtypes

Co-authored-by: jbrockmendel <jbrockmendel@gmail.com>
@meeseeksmachine @mtsokol
Backport PR #54694 on branch 2.1.x (MAINT: Remove np.in1d function …
503cef4 
…calls) (#54697)

Backport PR #54694: MAINT: Remove `np.in1d` function calls

Co-authored-by: Mateusz Sokół <8431159+mtsokol@users.noreply.github.com>
@meeseeksmachine @AdrianDAlessandro
Backport PR #54625 on branch 2.1.x (BUG: Fix error in printing timezo…
dc27aee 
…ne series) (#54698)

Backport PR #54625: BUG: Fix error in printing timezone series

Co-authored-by: Adrian D'Alessandro <a.dalessandro@imperial.ac.uk>
@meeseeksmachine @lukemanley
Backport PR #54508 on branch 2.1.x (PERF: DataFrame.iloc[int] for EA …
968b517 
…dtypes) (#54700)

Backport PR #54508: PERF: DataFrame.iloc[int] for EA dtypes

Co-authored-by: Luke Manley <lukemanley@gmail.com>
meeseeksmachine and others added 24 commits October 25, 2023 16:22
@meeseeksmachine @lithomas1
Backport PR #55586 on branch 2.1.x (REGR: Groupby methods not support…
0a44346 
…ing numba raising TypeError when the…) (#55686)

Backport PR #55586: REGR: Groupby methods not supporting numba raising TypeError when the…

Co-authored-by: Thomas Li <47963215+lithomas1@users.noreply.github.com>
@meeseeksmachine @hkhojasteh
Backport PR #55173 on branch 2.1.x (BUG: .rolling() returns incorrect…
bceb84b 
… values when ts index is not nano seconds) (#55697)

Backport PR #55173: BUG: .rolling() returns incorrect values when ts index is not nano seconds

Co-authored-by: Hadi Abdi Khojasteh <hadiabdikhojasteh@gmail.com>
@rhshadrach @Charlie-XIAO
Backport PR #55527: BUG fix deprecation of limit and fill_method … (
47a7cbf 
#55701)

Backport PR #55527: BUG fix deprecation of `limit` and `fill_method` in `pct_change`

Co-authored-by: Yao Xiao <108576690+Charlie-XIAO@users.noreply.github.com>
@jorisvandenbossche
Backport PR #55690 on branch 2.1.x (REGR: fix roundtripping datetimes…
8059d86 
… with sqlite type detection) (#55702)

REGR: fix roundtripping datetimes with sqlite type detection (#55690)

(cherry picked from commit aeb3644)
@jorisvandenbossche
Backport PR #54922 on branch 2.1.x (REGR: Restore _constructor_from_m…
9c7b567 
…gr to pass manager object to constructor) (#55704)

Backport PR #54922: REGR: Restore _constructor_from_mgr to pass manager object to constructor
@meeseeksmachine @jorisvandenbossche
Backport PR #55691 on branch 2.1.x (REGR: fix read_parquet with colum…
16a3b01 
…n of large strings (avoid overflow from concat)) (#55706)

Backport PR #55691: REGR: fix read_parquet with column of large strings (avoid overflow from concat)

Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
@lithomas1
RLS: 2.1.2
a60ad39
@meeseeksmachine @jorisvandenbossche
Backport PR #55722 on branch 2.1.x (DOC: Add whatsnew for 2.1.3) (#55723
d11fa8d 
)

Backport PR #55722: DOC: Add whatsnew for 2.1.3

Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
@meeseeksmachine @mroeschke
Backport PR #55707 on branch 2.1.x (REF: Avoid np.can_cast for scalar…
c5da5ea 
… inference for NEP 50) (#55716)

Backport PR #55707: REF: Avoid np.can_cast for scalar inference for NEP 50

Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
@meeseeksmachine @lithomas1
Backport PR #55747 on branch 2.1.x (DOC: Fix release date for 2.1.2) (#…
08f2bd4 
…55749)

Backport PR #55747: DOC: Fix release date for 2.1.2

Co-authored-by: Thomas Li <47963215+lithomas1@users.noreply.github.com>
@meeseeksmachine @WillAyd
Backport PR #55726 on branch 2.1.x (fix segfault with tz_localize_to_…
bf91684 
…utc) (#55796)

Backport PR #55726: fix segfault with tz_localize_to_utc

Co-authored-by: William Ayd <will_ayd@innobi.io>
@meeseeksmachine @mroeschke
Backport PR #55817 on branch 2.1.x (COMPAT: Numpy int64 Windows defau…
8a616b9 
…lt for Numpy 2.0) (#55851)

Backport PR #55817: COMPAT: Numpy int64 Windows default for Numpy 2.0

Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
@lukemanley
Backport PR #55761 on branch 2.1.x (BUG: DatetimeIndex.diff raising T…
0bf70c7 
…ypeError) (#55819)

* Backport PR #55473: TST: sort index with sliced MultiIndex

* BUG: DatetimeIndex.diff raising TypeError (#55761)

* BUG: DatetimeIndex.diff raising TypeError

* add test and whatsnew

* typing

* use Index

(cherry picked from commit f04da3c)

* fix whatsnew
@mroeschke
Backport PR #55853: DEPS: Use ipython run_cell instead of run_code; r…
7702f41 
…emove pytest-asyncio (#55858)
@mroeschke
TST: Make read_csv tests pyarrow 13 compatable on 2.1.x (#55855)
c9854d9 
* TST: Make read_csv tests pyarrow 13 compatable on 2.1.x

* Skip on windows for ARROW_TIMEZONE_DATABASE
@meeseeksmachine @MarcoGorelli
Backport PR #55227 on branch 2.1.x (BUG: Interchange object data buff…
569f904 
…er has the wrong dtype / from_dataframe incorrect ) (#55863)

Backport PR #55227: BUG: Interchange object data buffer has the wrong dtype / from_dataframe incorrect

Co-authored-by: Marco Edward Gorelli <marcogorelli@protonmail.com>
Co-authored-by: MarcoGorelli <33491632+MarcoGorelli@users.noreply.github.com>
@meeseeksmachine @cobaltt7
Backport PR #55427 on branch 2.1.x (DOC: Remove outdated docs about N…
de8af3c 
…umPy's broadcasting) (#55896)

Backport PR #55427: DOC: Remove outdated docs about NumPy's broadcasting

Co-authored-by: cobalt <61329810+RedGuy12@users.noreply.github.com>
@meeseeksmachine @ivirshup
Backport PR #55764 on branch 2.1.x (REGR: fix return class in _constr…
4158666 
…uctor_from_mgr for simple subclasses) (#55892)

Backport PR #55764: REGR: fix return class in _constructor_from_mgr for simple subclasses

Co-authored-by: Isaac Virshup <ivirshup@gmail.com>
@jorisvandenbossche
Backport PR #55894 on 2.1.x: Parquet/Feather IO: disable PyExtensionT…
1691a51 
…ype autoload (#55900)

Parquet/Feather IO: disable PyExtensionType autoload (#55894)

* Parquet/Feather IO: disable PyExtensionType autoload

* don't install hotfix for pyarrow >= 14.0.1

* move patching to extension type definitions

* expand error message

* fix compat for pyarrow not installed

* add whatsnew

(cherry picked from commit 851fea0)
@meeseeksmachine @lithomas1
Backport PR #55907 on branch 2.1.x (DOC: Add release date for 2.1.3) (#…
92ce245 
…55913)

Backport PR #55907: DOC: Add release date for 2.1.3

Co-authored-by: Thomas Li <47963215+lithomas1@users.noreply.github.com>
@meeseeksmachine @jorisvandenbossche
Backport PR #55911 on branch 2.1.x (DOC: convert outdated example of …
d9665ca 
…NumPy's broadcasting to literal code block) (#55912)

Backport PR #55911: DOC: convert outdated example of NumPy's broadcasting to literal code block

Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
@jorisvandenbossche
RLS: 2.1.3
2a953cf
@AnushaUKumar
WIP: assign() validation for tuple keys
467bef2
@AnushaUKumar
BUG: Raise clear error when assign is used with non-string column keys
6846be4
@mroeschke
Copy link
Member

Thanks for the PR, but it appears there a lot of changes in unrelated files. Going to close this PR, but ensure that pull requests are made from the latest commit on main

@mroeschke mroeschke closed this Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhshadrach rhshadrach Awaiting requested review from rhshadrach rhshadrach is a code owner

@WillAyd WillAyd Awaiting requested review from WillAyd

@mroeschke mroeschke Awaiting requested review from mroeschke mroeschke is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@AnushaUKumar @mroeschke @meeseeksmachine @phofl @lithomas1 @lukemanley @rhshadrach @jorisvandenbossche