-
-
Notifications
You must be signed in to change notification settings - Fork 19.2k
BUG: read_csv skipping a line with double quotes #62855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: read_csv skipping a line with double quotes #62855
Conversation
|
Thanks for pointing that out! I've updated it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
doc/source/whatsnew/v3.0.0.rst
Outdated
| - Bug in :meth:`HDFStore.get` was failing to save data of dtype datetime64[s] correctly (:issue:`59004`) | ||
| - Bug in :meth:`HDFStore.select` causing queries on categorical string columns to return unexpected results (:issue:`57608`) | ||
| - Bug in :meth:`MultiIndex.factorize` incorrectly raising on length-0 indexes (:issue:`57517`) | ||
| - Bug in :meth:`python_parser` where :class:`MyDialect` did not appropriately skip a line when instructed, causing Empty Data Error (:issue:`62739`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whatsnew notes are for users and should only refer to the public API; both python_parser and MyDialect are not public. Can you rewrite - just :func:`read_csv` I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, just wondering if it should be :meth: instead of :func? it seems that other mentions of read_csv uses :meth: tag instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It makes no difference in the generated docs, so not a big deal either way, but read_csv is a function in the pandas namespace and not a method on a class.
|
pre-commit.ci autofix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
Thanks @georginas05 and @zephyrieal! |
doc/source/whatsnew/v3.0.0.rstfile if fixing a bug or adding a new feature.This is an edit to an existing branching statement inside
python_parser.pyand is fixed for the Python engine.