-
-
Notifications
You must be signed in to change notification settings - Fork 19.2k
BUG: use arrow backend for digits references in str.replace
#62872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mroeschke
merged 7 commits into
pandas-dev:main
from
Alvaro-Kothe:fix/regex-group-arrow
Oct 27, 2025
Merged
BUG: use arrow backend for digits references in str.replace
#62872
mroeschke
merged 7 commits into
pandas-dev:main
from
Alvaro-Kothe:fix/regex-group-arrow
Oct 27, 2025
+73
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also tests for ambiguous reference \d + another literal as digit.
5 tasks
mroeschke
approved these changes
Oct 27, 2025
mroeschke
reviewed
Oct 27, 2025
|
|
||
| Strings | ||
| ^^^^^^^ | ||
| - Bug in :meth:`Series.str.replace` raising an error on valid group references (``\1``, ``\2``, etc.) on series converted to PyArrow backend dtype (:issue:`62653`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noting if there will be a 2.3.4 release, this PR should probably be backported
|
Thanks @Alvaro-Kothe |
Alvaro-Kothe
added a commit
to Alvaro-Kothe/pandas
that referenced
this pull request
Oct 27, 2025
…-dev#62872) Co-authored-by: zishan044 <winchesterfelix007@gmail.com> (cherry picked from commit a947b55)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.I also had to update some tests, because PyArrow replacement differs from python
remodule, where inre, if you use a reference with another digit (e.g.,\10) it is considered invalid. In PyArrow, it's considered reference + literal.Additionally, I could only reproduce the error reported in #62653 when converting with
.convert_dtypes(dtype_backend="pyarrow"), constructing the series with an arrow dtype didn't reproduce.