-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
DOC: Remove ..versionchanged less than version 2.0 #62939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
pandas/core/frame.py
Outdated
| Warns that ``group_keys`` will no longer be ignored when the | ||
| result from ``apply`` is a like-indexed Series or DataFrame. | ||
| Specify ``group_keys`` explicitly to include the group keys or | ||
| not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not seeing the warning. Remove?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably have to update the text above then to reflect that change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah IMO probably OK to just remove this since the existing docstring is now strictly true without any caveats.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, yes, you're right, +1
pandas/core/shared_docs.py
Outdated
| Warns that ``group_keys`` will no longer be ignored when the | ||
| result from ``apply`` is a like-indexed Series or DataFrame. | ||
| Specify ``group_keys`` explicitly to include the group keys or | ||
| not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto.
Probably no longer needed as those pandas versions are +2 years old