Skip to content

STY: Add strict=True to zip() calls in pandas/core/reshape/concat.py #62983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2025
Merged

STY: Add strict=True to zip() calls in pandas/core/reshape/concat.py #62983

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pandas/core/reshape/concat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -840,7 +840,7 @@ def _make_concat_multiindex(indexes, keys, levels=None, names=None) -> MultiInde
if (levels is None and isinstance(keys[0], tuple)) or (
levels is not None and len(levels) > 1
):
zipped = list(zip(*keys))
zipped = list(zip(*keys, strict=True))
if names is None:
names = [None] * len(zipped)

Expand All @@ -866,13 +866,13 @@ def _make_concat_multiindex(indexes, keys, levels=None, names=None) -> MultiInde
# things are potentially different sizes, so compute the exact codes
# for each level and pass those to MultiIndex.from_arrays

for hlevel, level in zip(zipped, levels):
for hlevel, level in zip(zipped, levels, strict=True):
to_concat = []
if isinstance(hlevel, Index) and hlevel.equals(level):
lens = [len(idx) for idx in indexes]
codes_list.append(np.repeat(np.arange(len(hlevel)), lens))
else:
for key, index in zip(hlevel, indexes):
for key, index in zip(hlevel, indexes, strict=True):
# Find matching codes, include matching nan values as equal.
mask = (isna(level) & isna(key)) | (level == key)
if not mask.any():
Expand Down Expand Up @@ -922,7 +922,7 @@ def _make_concat_multiindex(indexes, keys, levels=None, names=None) -> MultiInde

# do something a bit more speedy

for hlevel, level in zip(zipped, levels):
for hlevel, level in zip(zipped, levels, strict=True):
hlevel_index = ensure_index(hlevel)
mapped = level.get_indexer(hlevel_index)

Expand Down
Loading