BUG: raise TypeError when array not like 1D in pandas.array #63210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@Alvaro-Kothe If I have done some mistake or any change is required, please tell me. |
Member
Alvaro-Kothe
left a comment
Alvaro-Kothe
left a comment
There was a problem hiding this comment.
This time, I have used np.array() for it to be time efficient like the _from_sequence method.
There are some benchmarks for array construction in asv_bench/benchmarks/array.py that you can use to measure performance impact. For guidance on how to run it, refer to the docs.
|
|
||
| # to avoid returning an array of string representation of objects. | ||
| if dtype == StringDtype(): | ||
| ndarr = np.array(data) |
Member
There was a problem hiding this comment.
I don't like this for the following reasons:
- It's weird to convert to
np.arraywhile callingpd.arrayand not use it. - The conversion in
np.arraycan raise, e.g., when we callnp.array([[1, 2], ["a"]]).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pandas.arrayworks fine when 2-D array contains string #63112Follows from #63173. I'm Sorry, but the last commit of the PR showed "Processing updates" for a long time. So, I closed that.