BUG: Fix regression in to_hdf with MultiIndex and StringDtype (GH#63412) #63414
+13
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Dec 18, 2025
pandas/io/pytables.py
Outdated
| ) | ||
| # GH 63412 | ||
| if isinstance(lev.dtype, StringDtype): | ||
| lev = lev.astype(object) |
Member
There was a problem hiding this comment.
If you replace this with pass, does _convert_index below already convert this data correctly without the astype?
Contributor
Author
There was a problem hiding this comment.
Yes it does. I'll make the modification.
Contributor
Author
There was a problem hiding this comment.
@mroeschke Checks passed. I used a different implementation to avoid the two if blocks, I think this is better style, unless you disagree.
mroeschke
added
IO HDF5
mroeschke
approved these changes
Dec 18, 2025
Member
|
Thanks @zacharym-collins |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.AGENTS.md.Summary
NotImplementedErrorwhen savingMultiIndexwithStringDtypeto HDF5.pandas/tests/io/pytables/test_store.py.test_put.py,test_read.py, andtest_round_trip.pythat were previously skipped forStringDtype.