PERF: Avoid internal copies in Index.__new__ #63438
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhshadrach
added
Performance
jorisvandenbossche
approved these changes
Dec 20, 2025
| else: | ||
| values = np.concatenate([x._values for x in rng_indexes]) | ||
| result = self._constructor(values) | ||
| result = self._constructor(values, copy=False) |
Member
There was a problem hiding this comment.
there is a similar self._constructor(values) call a few lines above at 1234, where you can add a copy=False as well, I think
mroeschke
approved these changes
Dec 20, 2025
Member
|
Thanks @rhshadrach feel free to follow up with other areas that need |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.AGENTS.md.This should address all regressions identified in pandas-dev/asv-runner#85 that we can due to #63370. I suspect there might be more places we want to pass
copy=False, but haven't thought of a good way to find them.The one regression that will remain is the benchmark of the Index constructor on taking an array, which is expected.