fix: show map editor on launch #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(NET7 Branch) After upgrading to .NET7, The MapGrid window shows up selected instead of the MapEditor when starting the editor. Seeing the code, this is what actually makes sense, no idea why it wasn't behaving like this before but the expected behavior is to have the MapEditor to show up, thus, this commit sets it to be shown by the end, giving us back the expected results.
pandinocoder
approved these changes
Mar 13, 2023
pandinocoder
pushed a commit
that referenced
this pull request
Mar 23, 2023
(NET7 Branch) After upgrading to .NET7, The MapGrid window shows up selected instead of the MapEditor when starting the editor. Seeing the code, this is what actually makes sense, no idea why it wasn't behaving like this before but the expected behavior is to have the MapEditor to show up, thus, this commit sets it to be shown by the end, giving us back the expected results.
pandinocoder
pushed a commit
that referenced
this pull request
Mar 23, 2023
(NET7 Branch) After upgrading to .NET7, The MapGrid window shows up selected instead of the MapEditor when starting the editor. Seeing the code, this is what actually makes sense, no idea why it wasn't behaving like this before but the expected behavior is to have the MapEditor to show up, thus, this commit sets it to be shown by the end, giving us back the expected results.
pandinocoder
pushed a commit
that referenced
this pull request
Mar 26, 2023
(NET7 Branch) After upgrading to .NET7, The MapGrid window shows up selected instead of the MapEditor when starting the editor. Seeing the code, this is what actually makes sense, no idea why it wasn't behaving like this before but the expected behavior is to have the MapEditor to show up, thus, this commit sets it to be shown by the end, giving us back the expected results.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(NET7 Branch)
After upgrading to .NET7, The MapGrid window shows up selected instead of the MapEditor when starting the editor. Seeing the code, this is what actually makes sense, no idea why it wasn't behaving like this before but the expected behavior is to have the MapEditor to show over when starting the editor, thus:
this commit sets the MapEditor to be shown by the end, giving us back the expected results.