Skip to content

fix: use Critical urgency for prompt notifications#246

Merged
pando85 merged 1 commit into
masterfrom
fix/critical-urgency-notifications
Apr 27, 2026
Merged

fix: use Critical urgency for prompt notifications#246
pando85 merged 1 commit into
masterfrom
fix/critical-urgency-notifications

Conversation

@forkline-bot
Copy link
Copy Markdown
Contributor

@forkline-bot forkline-bot Bot commented Apr 27, 2026

Summary

Users with DND (Do Not Disturb) enabled would not see a verification prompt notification when attempting to use a passkey, which was confusing and frustrating. Using the "Critical" urgency setting will force these prompts to appear appropriately, closer to a true modal dialog.

Changes

  • Added Urgency::Critical to the notification urgency setting in show_verification_notification
  • Added Urgency::Critical to the notification urgency setting in show_yes_no_notification

This ensures that user verification prompts bypass DND filters and are always visible when needed for security operations.


This PR was generated by Forkline — AI-powered code contributions.
The agent analyzed the issue and implemented this fix autonomously.

Users with DND (Do Not Disturb) enabled would not see a verification
prompt notification when attempting to use a passkey, which was
confusing and frustrating. Using the "Critical" urgency setting will
force these prompts to appear appropriately, closer to a true modal
dialog.
@forkline-bot
Copy link
Copy Markdown
Contributor Author

forkline-bot Bot commented Apr 27, 2026

Final Maintainability Review

Decision: No changes applied - the PR is clean and focused.

PR Assessment

Item Status
Import formatting Correct
Builder pattern usage Correct
Code documentation Good
Tests Adequate for unit testing
Change scope Focused and minimal

What's Good

  • The urgency change is well-documented in the commit message
  • Import follows project convention (std first, then external crates)
  • Builder chain syntax is correct with semicolons/commas properly placed
  • Urgency::Critical applied only to user-action-required notifications (verification/yes-no), not info/error which is intentional

Deferred Recommendations (outside PR scope)

  1. main.rs:14-18 - std::sync imports could be grouped
  2. authenticator.rs:478 - mutex .unwrap() could use graceful handling

These are minor and in different modules; addressing them would expand scope unnecessarily.

@pando85 pando85 merged commit d1214bd into master Apr 27, 2026
5 checks passed
@pando85 pando85 deleted the fix/critical-urgency-notifications branch April 27, 2026 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant