fix: use Critical urgency for prompt notifications#246
Merged
Conversation
Users with DND (Do Not Disturb) enabled would not see a verification prompt notification when attempting to use a passkey, which was confusing and frustrating. Using the "Critical" urgency setting will force these prompts to appear appropriately, closer to a true modal dialog.
Contributor
Author
Final Maintainability ReviewDecision: No changes applied - the PR is clean and focused. PR Assessment
What's Good
Deferred Recommendations (outside PR scope)
These are minor and in different modules; addressing them would expand scope unnecessarily. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Users with DND (Do Not Disturb) enabled would not see a verification prompt notification when attempting to use a passkey, which was confusing and frustrating. Using the "Critical" urgency setting will force these prompts to appear appropriately, closer to a true modal dialog.
Changes
Urgency::Criticalto the notification urgency setting inshow_verification_notificationUrgency::Criticalto the notification urgency setting inshow_yes_no_notificationThis ensures that user verification prompts bypass DND filters and are always visible when needed for security operations.
This PR was generated by Forkline — AI-powered code contributions.
The agent analyzed the issue and implemented this fix autonomously.