Skip to content

release: Version 0.11.1#359

Merged
pando85 merged 5 commits into
masterfrom
release/v0.11.1
May 18, 2026
Merged

release: Version 0.11.1#359
pando85 merged 5 commits into
masterfrom
release/v0.11.1

Conversation

@forkline-bot
Copy link
Copy Markdown

@forkline-bot forkline-bot Bot commented May 18, 2026

Changes

  • fix(ci): Handle shallow clones in release script

*This PR was generated by Forkline — AI-powered code contributions.
The agent analyzed the issue and implemented this fix autonomously.

forkline-dev[bot] added 2 commits May 18, 2026 13:20
- Replace panic-inducing .unwrap() chain in beep.rs get_device() with
  graceful error handling using .ok(), .flatten(), and filter_map()
- Remove unreachable code in timer.rs where BEEP_DELAY - SOUND_START_DELAY
  was always 0 (both are 100), making the condition always false
@forkline-bot
Copy link
Copy Markdown
Author

forkline-bot Bot commented May 18, 2026

Maintainability Review Completed

Applied Changes (committed to PR branch):

  1. src/beep.rs:28-43 - Fixed panic risk in device discovery

    • Replaced .unwrap() chain with graceful error handling using .ok(), .flatten(), and filter_map()
    • Prevents CLI crash when encountering non-UTF8 device paths
    • Risk: Low - Behavior unchanged for normal paths, now gracefully skips problematic ones
  2. src/timer.rs:137-140 - Removed dead code

    • The condition BEEP_DELAY - SOUND_START_DELAY > 0 was always false (100-100=0)
    • Removed unreachable sleep statement and clippy suppression
    • Risk: None - Code was never executed

Deferred (not worth the churn):

  • timer.rs:55-93 - Code duplication in parse_end_time for time format parsing. Valid refactor but would require careful changes and tests. Low urgency.

  • main.rs:104 - exit(0) from spawned thread. Works correctly for this CLI use case. Not a practical issue.


This PR was generated by Forkline — AI-powered code contributions.
The agent analyzed the issue and implemented this fix autonomously.

@forkline-bot
Copy link
Copy Markdown
Author

forkline-bot Bot commented May 18, 2026

Fix pushed:

Fixed glob crate API change - glob() iterator now returns Result<PathBuf, GlobError> instead of PathBuf. Added .ok() to unwrap the Result before calling to_str().

@pando85 pando85 merged commit cc67aa6 into master May 18, 2026
5 checks passed
@pando85 pando85 deleted the release/v0.11.1 branch May 18, 2026 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant