Invalid syntax highlighting for tagged template strings

[chocolateboy]

vim-javascript: 0.10.0 (e9709a9)
vim: 7.4.52
OS: Linux (Ubuntu 14.04.1)

Syntax highlighting doesn't seem to be handling tagged template strings correctly e.g.:

foo(test`foo`, "bar", baz);

- highlights everything up to the closing backtick correctly (i.e. the tag is green and the template and its delimiters are red), but everything after that is green (to the end of the line). This also breaks highlighting for other elements e.g.:

it('highlights tagged templates', function () {
    assert.equal(test`foo`, 'foo');
}); // <- closing curly bracket highlighted in red

- highlights the closing curly bracket as an error (red).

[goatslacker]

A quick solution would be to remove the contains=jsTemplateStrings for jsTaggedTemplate this would however highlight the tag + the string as a StorageClass.

[amadeus]

Actually, I think all we need is keepend added to the jsTaggedTemplate region

[amadeus]

And I don't really use anything ES6 these days, but I believe the end matcher on jsTaggedTemplate is wrong. Aren't these template strings supposed to be able to span multiple lines? Currently the ending regex is

+`\|$+

which ends the template string with a linebreak, which I think is incorrect?

[goatslacker]

We can remove the $ and add keepend.

[raine]

Broken as such:

[epaminond]

It seems I have the same issue on neovim.

[amadeus]

@epaminond there appear to be 2 separate issues in here. Can you specify which issue or post a code snippet?

[epaminond]

@amadeus, syntax highlighting for template strings doesn't take into account closing back quote:

[amadeus]

Thanks, @epaminond I'll take a look into this shortly. In the meantime could you paste that snippet as text in a comment so I can easily test it?

[epaminond]

Thanks. Here's a snippet:

<div className={`caption ${this.isInPast(day, day) ? 'progress' : ''}`}>
  {day.format('dd - MMM DD')}
</div>