fix: Highlight arrow functions with bare single params #276
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arrow expressions with "naked" single parameters are currently not being recognized as such, due to the mis-labeling of the expression as assignment. ```js // The part: `x =` looks like assignment to syntax rules: let myFunc = x => 3; ``` This change introduces a negative lookahead for the `>` character in the assignment matcher.
Collaborator
|
Slightly nervous about the lookahead, but let's try it and see if anyone reports bad behaviour / slowness |
qstrahl
added a commit
that referenced
this pull request
Jul 17, 2015
fix: Highlight arrow functions with bare single params
Collaborator
|
Thanks, @ccarpita! |
Contributor
Author
|
Good point about the lookahead, though it's single char and should evaluate quickly for assignment expressions. If the performance suffers we should probably create a region type for the full arrow expressions with prioritized matching over assignment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arrow expressions with "naked" single parameters are currently not being
recognized as such, due to the mis-labeling of the expression as assignment.
This change introduces a negative lookahead for the
>character inthe assignment matcher.
Issue: GH-272