A few changes from last Huntsman observing run#511
Closed
wtgee wants to merge 12 commits intopanoptes:developfrom
Closed
A few changes from last Huntsman observing run#511wtgee wants to merge 12 commits intopanoptes:developfrom
wtgee wants to merge 12 commits intopanoptes:developfrom
Conversation
Member
wtgee
commented
Apr 12, 2018
wtgee
commented
- Make sure observation is still in valid list.
- Link pretty image from FITS to latest
- Weather plot fixes
Codecov Report
@@ Coverage Diff @@
## develop #511 +/- ##
===========================================
- Coverage 70.46% 67.78% -2.69%
===========================================
Files 62 62
Lines 5418 5419 +1
Branches 752 752
===========================================
- Hits 3818 3673 -145
- Misses 1392 1546 +154
+ Partials 208 200 -8
Continue to review full report at Codecov.
|
wtgee
added a commit
to wtgee/POCS
that referenced
this pull request
May 1, 2018
* Locking pycodestyle until fix in panoptes#511, panoptes#512, panoptes#514
Merged
jamessynge
pushed a commit
that referenced
this pull request
May 7, 2018
…man-run-updates
jamessynge
requested changes
May 26, 2018
| end_of_next_set = time + self.current_observation.set_duration | ||
| if end_of_next_set < common_properties['end_of_night'] and \ | ||
| self.observation_available(self.current_observation, end_of_next_set): | ||
| if (end_of_next_set < common_properties['end_of_night'] and |
Contributor
There was a problem hiding this comment.
I'm struggling to decipher this expression. Please add more detail to the preceding comment.
| return _make_pretty_from_fits(fname, **kwargs) | ||
| new_fname = _make_pretty_from_fits(fname, **kwargs) | ||
|
|
||
| try: |
Contributor
There was a problem hiding this comment.
Please add a comment such as:
# Symlink latest.jpg to the image; first remove the symlink if it already exists.
|
|
||
| print('Saving Figure: {}'.format(plot_filename)) | ||
| self.fig.savefig(plot_filename, dpi=self.dpi, bbox_inches='tight', pad_inches=0.10) | ||
| self.fig.tight_layout() |
Contributor
There was a problem hiding this comment.
I don't know what this is doing.
…man-run-updates
Member
Author
|
I had added two new things from the latest of Huntsman runs:
|
This was referenced Jul 10, 2018
Member
Author
|
Closing in favor of issues listed above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.