Skip to content

Fixing the logic for the scheduling state#517

Merged
wtgee merged 2 commits intopanoptes:developfrom
wtgee:fix-scheduling-state
May 8, 2018
Merged

Fixing the logic for the scheduling state#517
wtgee merged 2 commits intopanoptes:developfrom
wtgee:fix-scheduling-state

Conversation

@wtgee
Copy link
Copy Markdown
Member

@wtgee wtgee commented May 7, 2018

Fixing regression introduced by #488

@wtgee wtgee requested a review from jamessynge May 7, 2018 20:28
@codecov
Copy link
Copy Markdown

codecov bot commented May 7, 2018

Codecov Report

Merging #517 into develop will increase coverage by 2.47%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop    #517      +/-   ##
==========================================
+ Coverage    67.92%   70.4%   +2.47%     
==========================================
  Files           62      62              
  Lines         5419    5419              
  Branches       752     752              
==========================================
+ Hits          3681    3815     +134     
+ Misses        1541    1396     -145     
- Partials       197     208      +11
Impacted Files Coverage Δ
pocs/state/states/default/scheduling.py 69.56% <0%> (+13.04%) ⬆️
pocs/state/machine.py 88.96% <0%> (-4.14%) ⬇️
pocs/core.py 77.16% <0%> (-0.4%) ⬇️
pocs/serial_handlers/protocol_arduinosimulator.py 76.53% <0%> (-0.39%) ⬇️
pocs/utils/images/__init__.py 77.07% <0%> (+1.27%) ⬆️
pocs/mount/mount.py 57.01% <0%> (+1.31%) ⬆️
pocs/mount/simulator.py 92.79% <0%> (+1.8%) ⬆️
pocs/utils/images/fits.py 82.38% <0%> (+5.11%) ⬆️
pocs/camera/simulator.py 100% <0%> (+5.45%) ⬆️
pocs/camera/camera.py 89.5% <0%> (+5.52%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39a2338...884b1be. Read the comment docs.

@wtgee wtgee merged commit 1bda9aa into panoptes:develop May 8, 2018
@wtgee wtgee deleted the fix-scheduling-state branch May 8, 2018 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant