Check safety during transition

[wtgee]

If the state doesn't successfully change, check the safety between each iteration and if False send to parking

Note: still trying to figure out how to test this

Fixes #504

[codecov]

Codecov Report

Merging #518 into develop will decrease coverage by 0.13%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           develop     #518      +/-   ##
===========================================
- Coverage    70.46%   70.33%   -0.14%     
===========================================
  Files           62       62              
  Lines         5418     5423       +5     
  Branches       752      753       +1     
===========================================
- Hits          3818     3814       -4     
- Misses        1392     1401       +9     
  Partials       208      208

Impacted Files	Coverage Δ
pocs/state/machine.py	86% <0%> (-2.97%)	⬇️
pocs/serial_handlers/protocol_arduinosimulator.py	75.38% <0%> (-1.16%)	⬇️
pocs/camera/camera.py	89.5% <0%> (-1.11%)	⬇️
pocs/dome/astrohaven.py	73.68% <0%> (+0.87%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17754d0...e658bc6. Read the comment docs.

[jamessynge]

Let's add logging to indicate what is going on. For example:

if not state_changed:
    self.logger.warning("Failed to transition from {} to {}", self.state, self.next_state)
    if not self.is_safe():
        self.logger.warning("Conditions have become unsafe; setting next state to 'parking'")
        self.next_state = 'parking'
    elif _loop_iteration > 5:
        self.logger.warning("Stuck in current state for 5 iterations, parking")
        self.next_state = 'parking'
    else:
        _loop_iteration = _loop_iteration + 1
        self.logger.warning("Sleeping for a bit, then trying the transition again (loop: {})",
                                       _loop_iteration)
        self.sleep(with_status=False)