Add a config file for test_codestyle.py#594
Merged
wtgee merged 1 commit intopanoptes:developfrom Sep 15, 2018
Merged
Conversation
pycodestyle supports reading config options from a file. This change adds such a file and modifies test_codestyle.py to reference it. Removes ignoring of E402 (module level import not at top of file) because we don't violate it now. Sets the line length to 99, but continues to ignore E501 (line too long) because we have a lot of those.
wtgee
approved these changes
Sep 15, 2018
Member
wtgee
left a comment
wtgee
left a comment
There was a problem hiding this comment.
I'm curious to see if this is different than the linting that I use with my editor, which doesn't use pyflakes.
But definitely happy to have this in. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pycodestyle supports reading config options from a file.
This change adds such a file and modifies test_codestyle.py
to reference it.
Removes ignoring of E402 (module level import not at top of file)
because we don't violate it now.
Sets the line length to 99, but continues to ignore E501 (line
too long) because we have a lot of those.