Only use Mongo DB type during local testing - Local Testing with 1/3rd the wait!#616
Merged
wtgee merged 3 commits intopanoptes:developfrom Sep 21, 2018
Merged
Conversation
* Adds `--test-all-databases` option which is False by default but enabled for travis tests.
jamessynge
reviewed
Sep 20, 2018
| @@ -214,6 +219,10 @@ def can_connect_to_mongo(): | |||
|
|
|||
| @pytest.fixture(scope='function', params=['mongo', 'file', 'memory']) | |||
Contributor
There was a problem hiding this comment.
FWIW, I'd prefer an additional option that is the list of dbs to be tested, which then would provide the value for params.
Member
Author
There was a problem hiding this comment.
That's almost what I did. Would be easy enough to change if we feel it is worth it do to right now.
Member
Author
There was a problem hiding this comment.
I changed it to support this now. Call with, e.g. pytest -xv --test-databases file memory. Supports an all option (which travis uses). Default 'mongo' only.
jamessynge
approved these changes
Sep 20, 2018
…use-mongo-testing-locally
* Travis tests all by default
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
* Adds--test-all-databasesoption which is False by default but enabled for travis tests.Edit: Added
--test-databases [<db_name>]option to support testing of certain db types.Call with, e.g.
pytest -xv --test-databases file memory. Supports an all option (which travis uses). Default 'mongo' only.Helps with #191 .