ci: pin github action with full-length commit hash#40
ci: pin github action with full-length commit hash#40ostk0069 wants to merge 1 commit intopantsbuild:mainfrom
Conversation
|
@jsirois Could you please review this? |
|
@ostk0069 I am no longer a committer in this org; so I'm not sure if sha pinning is what is desired. You probably want @benjyw , @sureshjoshi or @tdyas to take a look. |
|
@sureshjoshi I need your review, please. |
|
Thanks for the PR @ostk0069. We haven't yet agreed to require SHA pinning (something we'd likely roll out across all repos together). At the moment, the approach I tend to take is to pin major (or major.minor) versions of the platform provider (i.e. GitHub), and then SHA pin basically everyone else. That meets a reasonable security risk-reward tolerance (to me, anyways). However, this PR did point out that we don't have Dependabot running here to handle these upgrade reminders, so I went ahead and opened #41. Thanks for the reminder. |
In order to enable
Require actions to be pinned to a full-length commit SHAsetting, this diff is necessary.