Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datalink ID start value somewhat confusing #1098

Closed
OpenUAS opened this issue Feb 11, 2015 · 2 comments
Closed

Datalink ID start value somewhat confusing #1098

OpenUAS opened this issue Feb 11, 2015 · 2 comments
Labels
GCS Minor
Milestone
v5.4.2

Comments

@OpenUAS
Copy link
Contributor

OpenUAS commented Feb 11, 2015

The current message of a new link detected starts with index 0. From programmers perspective quite OK. Various ground station operators however where somewhat confused, to put it mildly.
The 0 sounded to them "Oh, no, I lost my connection..."

  1. Rather start at 1. aka the first link....

  2. And adding in ID in front of the value makes it much clearer specifically when speech is enabled.
    and the "new link detected" could do without the New, specifically when speech is enabled it should be as short.

The preference would be:

Datalink detected with ID X

or maybe even better:

Datalink X connected

With multiple links this still sounds OK like

Datalink 1 connected, Datalink 4 connected Datalink 3 connected

Although ith multiple links one could ague they are only detected and not used as backup link thus not "Connected", but that discussion can land up in another issue.
@OpenUAS OpenUAS added GCS Enhancement Improve upon exiting functionality Minor labels Feb 11, 2015
@OpenUAS OpenUAS added this to the v5.4.2 milestone Feb 11, 2015
@OpenUAS OpenUAS changed the title Datalink ID start value Datalink ID start value somewhat confusing Feb 11, 2015
gautierhattenberger added a commit that referenced this issue Mar 3, 2015
@gautierhattenberger
[link] index of single link is called "single"
afbdd4a 
and speech text is shorter
see #1098
gautierhattenberger added a commit that referenced this issue Mar 3, 2015
@gautierhattenberger @flixr
[link] index of single link is called "single"
4e378b3 
and speech text is shorter
see #1098
@flixr
Copy link
Member

flixr commented Mar 9, 2015

@OpenUAS if you are happy with the solution of @gautierhattenberger (added to master with 4e378b3), we can backport it to v5.4 and then close this issue...

@flixr flixr removed the Enhancement Improve upon exiting functionality label Mar 10, 2015
gautierhattenberger added a commit that referenced this issue Mar 16, 2015
@gautierhattenberger @flixr
[link] index of single link is called "single"
80cc06b 
and speech text is shorter
see #1098
@flixr
Copy link
Member

flixr commented Mar 16, 2015

Feedback timeout...
Backported to v5.4 with 80cc06b

@flixr flixr closed this as completed Mar 16, 2015
Fab7c4 pushed a commit to Fab7c4/paparazzi that referenced this issue May 24, 2015
Merge tag 'v5.4.2_stable' into highwind
a54ebcf 
Paparazzi 5.4.2_stable
======================

Maintenance release

- GCS: fix undo for list of values
  [paparazzi#1054] (paparazzi#1054)
- lisa_mx: fix secondary spektrum satellite UART AF
- logalizer: fix csv export after allowing description tag in messages
- nps: update nps_fdm_jsbsim to be compatible with latest jsbsim
  [paparazzi#1118] (paparazzi#1118)
- rotorcraft: fix attitude flight plan primitive
  [paparazzi#1103] (paparazzi#1103)
- flight plans: fix 'call' statement without loop
- generators: only include raw makefile part from modules if target matches
- GCS: GPS accuracy speech less verbose
  [paparazzi#1046] (paparazzi#1046)
- GCS: call index of first/single link "single"
  [paparazzi#1098] (paparazzi#1098)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
GCS Minor
Projects
None yet
Milestone
v5.4.2
Development

No branches or pull requests
2 participants
@flixr @OpenUAS