Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aiframe cleanup #1249

Closed
wants to merge 4 commits into from
Closed

Aiframe cleanup #1249

wants to merge 4 commits into from

Conversation

podhrmic
Copy link
Member

unused airframe xml files fronm conf_example and conf_test.xml were moved to obselete folder, see #1236 for more info.

@podhrmic podhrmic changed the title Aiframe cleanup - > Aiframe cleanup Jul 20, 2015
@flixr
Copy link
Member

flixr commented Jul 21, 2015

Should we really call the folder obsolete? Maybe we can find a better name...
Could you plz also update the conf_tests.xml?

@OpenUAS
Copy link
Contributor

OpenUAS commented Jul 21, 2015

I vote for '''untested''', gives less of expectancy for the outcome of using these airframes.

@podhrmic
Copy link
Member Author

Changed the name to "untested". Also the conf_tests.xml is updated.

@flixr
Copy link
Member

flixr commented Jul 21, 2015

One more thing that we should probably consider:
while these airframes are untested (in the sense that they are not part of the example or test conf), most of them should still work just fine.
But since they are moved one directory level lower now all of their relative paths to the airframe.dtd will be wrong.
Maybe it would make more sense to make the directory structure rather flat and similar between examples and untested, i.e.:

conf/airframes
   |
   |---- examples
   |    |
   |    |---- foo.xml
   |    |---- bar.xml
   |
   |---- untested
   |    |
   |    |---- baz.xml 

Then we could also more easily move a file from examples to untested and vice versa...

@podhrmic
Copy link
Member Author

I already did that.

@flixr
Copy link
Member

flixr commented Jul 21, 2015

@podhrmic Uhm... no...
e.g. conf/airframes/examples/beagle_bone_black.xml was renamed to conf/airframes/untested/examples/beagle_bone_black.xml without changes...
So adding another directory level...

@podhrmic
Copy link
Member Author

yes, so then you can move it from conf/airframes/untested/examples/beagle_bone_black.xml to conf/airframes/examples/beagle_bone_black.xml without any change. That is what we want, no?

@flixr
Copy link
Member

flixr commented Jul 21, 2015

But I want to be able to just compile/test an airframe file from the untested dir without having to do any changes or moving it to examples first.
So that is why I propose to have a flat tree, with no more subdirs under examples or untested...

@podhrmic
Copy link
Member Author

OK. Do you want all files in one folder (i.e. no subdirs in untested) or have

untested
untested-> examples
untested-> TestHardware

?

@flixr
Copy link
Member

flixr commented Jul 21, 2015

As I said I would vote for a flat tree, so no subfolders...
And you can delete the empty airframes from TestHardware...

@podhrmic
Copy link
Member Author

This should do it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants