Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ins velocity estimate #1412

Conversation

knmcguire
Copy link
Contributor

For now, just a pull request to the ins_velocity_estimate branch. Tomorrow I'll have another test flight, and then I'll send a pull request to master

@knmcguire
Copy link
Contributor Author

I figured out the scaling problem. There was an error in the calculation of the velocity estimate, which used image width and height in combination with the focal length in pixels, which is incorrect. I also added an alternative velocity estimate as a comment.

@knmcguire
Copy link
Contributor Author

how is it looking now, is it sufficient enough for a merge?

@knmcguire
Copy link
Contributor Author

I also see that most of the changes that I've made is mostly inside the optical flow module (which was not necessary the purpose of this branch). If this is not yet sufficient for merge, could at least the current status of ins_velocity_estimate on the paparazzi repository be merged with the master? I would like to proceed with not changing the existing optical flow module itself any more, but with a velocity estimate from an external camera module.

flixr added a commit that referenced this pull request Nov 11, 2015
- ins_int: listen to VELOCITY_ESTIMATE ABI messages and use it as measurement to update horizontal velocity
- add noise field to VELOCITY_ESTIMATE message
- opticflow module: fix velocity scaling and rotate to body frame
- update guidance opticflow hover module accordingly
@flixr flixr closed this Nov 11, 2015
@flixr
Copy link
Member

flixr commented Nov 11, 2015

Still TODO: actually calculate a realistic noise value (unit: m/s^2) in the opticflow module. Also we should decide if this should be the standard variation or already the variance (and rename that field as appropriate)...
Also do we want one value for this, or one per axis?
One per axis would be the best solution I think (not having a full covariance matrix, but just the diagonal).
Then you could also set the variance one one axis to Inf (or NaN) to indicate that that axis was not measured.

@knmcguire
Copy link
Contributor Author

Yes, that is still something to be determined. I think that some quality values need to be logged together with the velocity estimate error with an optitrack system, and see if there is a correlation between them. Then an adaptive noise value can be made. This will take some time though to get it right, so I will ask somebody in the Lab who will work specifically on the optical flow module as it is. If a realistic noise model can be fitted for this, then the guidance control can be very robust.

From: Felix Ruess [mailto:notifications@github.com]
Sent: woensdag 11 november 2015 13:34
To: paparazzi/paparazzi
Cc: Kimberly Mcguire - LR
Subject: Re: [paparazzi] Ins velocity estimate (#1412)

Still TODO: actually calculate a realistic noise value (unit: m/s^2) in the opticflow module. Also we should decide if this should be the standard variation or already the variance (and rename that field as appropriate)...
Also do we want one value for this, or one per axis?
One per axis would be the best solution I think (not having a full covariance matrix, but just the diagonal).
Then you could also set the variance one one axis to Inf (or NaN) to indicate that that axis was not measured.


Reply to this email directly or view it on GitHubhttps://github.com//pull/1412#issuecomment-155765223.

@flixr flixr added the Airborne label Nov 22, 2015
@flixr flixr added this to the v5.8 milestone Nov 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants