fix(lint): correct golangci.yml header — vendor pattern, not include URL#2
Merged
Merged
Conversation
The header comment promised:
Service repos extend via:
include:
- "https://raw.githubusercontent.com/paper-board/.github/main/golangci.yml"
golangci-lint v2 (2.11.x) does not actually accept top-level `include:` —
the JSONSchema validator rejects it as an additional property and the
config fails to load. The aspirational pattern misled the agents repo's
Task 26 work; correct the comment to document the actual practice
(vendor the file verbatim) plus the planned drift-CI guard so service
repos do not have to rediscover this.
Service-local override guidance kept inline so future readers know
where to add `linters.settings.*` and `linters.exclusions.rules`
without removing baseline rules.
Refs: paper-board/agents#14 (vendor copy that surfaced the issue);
agent-manager/tasks/2026-05-02-adr-0010-gap-analysis.md Task 26 status.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Greptile Summary
Confidence Score: 5/5Comment-only change; no runtime behavior is modified and the new instructions accurately reflect golangci-lint v2 constraints. No code is changed — only header comments are updated. The new guidance is factually correct (golangci-lint v2 does not support a top-level No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[paper-board/.github/golangci.yml\nbaseline] -->|vendor verbatim| B[service-repo/.golangci.yml]
B --> C{Need service-local overrides?}
C -->|path-based exclusions| D[linters.exclusions.rules\nin vendored copy]
C -->|linter config tweaks| E[linters.settings.*\nin vendored copy]
C -->|No overrides needed| F[Use as-is]
A -.->|planned: nightly drift CI\nservice-template Task 32| G[Diff vendored copies\nvs baseline → open issue on divergence]
Reviews (1): Last reviewed commit: "fix(lint): correct golangci.yml header —..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The shared
golangci.ymlheader comment previously promised:golangci-lint v2 (2.11.x) does NOT support
include:at the top level. The schema validator rejects it as an additional property and the entire config fails to load (jsonschema: "" does not validate with "/additionalProperties": additional properties 'include' not allowed).Discovered while doing
paper-board/agents#14(Task 26): consumer service tried to follow the comment, lint blew up, fell back to vendoring the file verbatim. Correcting the comment so future service repos don't repeat the cycle.What changed
include:example.linters.settings.*+linters.exclusions.rules) so future readers see where to layer service-local overrides without removing baseline rules.Why not implement URL include first
Test plan
golangci-lint config verifyagainst the vendored agents copy: passes.Refs:
paper-board/agents#14(vendor copy that surfaced the issue);agent-manager/tasks/2026-05-02-adr-0010-gap-analysis.mdTask 26 status.Generated with Claude Code.