docs(golangci): correct comment example to kebab-case ignore-package-globs#6
Merged
Merged
Conversation
…globs Comment example referenced the v1-style camelCase ignorePackageGlobs key. golangci-lint v2 schema rejects camelCase under wrapcheck (config verify fails); canonical name is ignore-package-globs. Bug surfaced when paper-board/agents wrapped its vendored .golangci.yml in golangci-lint-action@v9 (which runs config verify pre-lint) — the camelCase key in the agents copy failed validation. Comment update keeps the baseline accurate so future vendor copies don't repeat the mistake. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Greptile Summary
Confidence Score: 5/5Safe to merge — comment-only correction with no functional impact. The change is a single comment line fix correcting a stale v1 camelCase example to the v2 kebab-case canonical name. No schema, logic, or configuration values are affected. The fix is accurate per the golangci-lint v2 wrapcheck configuration spec. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[paper-board/.github\ngolangci.yml baseline] -->|vendor verbatim| B[Service repo\n.golangci.yml]
B -->|extend with| C["linters.settings.wrapcheck\nignore-package-globs:\n - 'github.com/paper-board/*/internal/*'"]
B -->|extend with| D["linters.exclusions.rules\nservice-specific overrides"]
E["golangci-lint-action@v9\nruns config verify"] -->|validates schema| B
E -->|rejects unknown keys| F["❌ camelCase ignorePackageGlobs\nfails v2 schema"]
E -->|accepts| G["✅ kebab-case ignore-package-globs\npasses v2 schema"]
Reviews (1): Last reviewed commit: "docs(golangci): correct comment example ..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Comment example in
golangci.ymlline 10 referenced the v1-style camelCaseignorePackageGlobs. golangci-lint v2 schema rejects camelCase under wrapcheck (config verifyfails); canonical name isignore-package-globs.Discovery
Bug surfaced when paper-board/agents wrapped its vendored
.golangci.ymlingolangci-lint-action@v9(which runsconfig verifypre-lint). Earlier action versions (v6) skipped that verify step + earlier binary versions silently ignored unknown keys, so the typo went undetected through Tasks 26-29.Why comment-only
The actual
linters.settings.wrapcheckblock is empty in this baseline (services add their own ignore lists in vendored copies). The error only manifested in agents/.golangci.yml. Fixed there in paper-board/agents42c45ee. This PR is purely documentation drift correction so future vendor copies don't propagate the wrong example.Test plan
🤖 Generated with Claude Code