polish(security): inline ⧉N blast badge + unify the ignore icon#330
Merged
Conversation
- Cross-session radius: replace the standalone "Also in N other sessions" line under each credential value with a compact ⧉N badge on the value row (Layers glyph + count, tooltip carries the label). Clicking expands the per-session list. BlastRadius is now controlled — it reports the other-session count up (drives the badge) and renders the list only when expanded — so a collapsed radius costs zero extra rows. - Ignore icon consistency: "ignore/dismiss" now uses CircleSlash everywhere — the per-row Dismiss trigger (SecurityPage + FindingsStrip) becomes an icon-only button (tooltip + scope menu) instead of a text label, and the "Dismiss all" bulk menu item swaps its mis-leading ✓ Check for CircleSlash. Check stays only on true "resolved" status badges. The hairline between the per-row Dismiss and Purge icons is dropped so the two read as a clean icon pair. Tests: security-blast-radius e2e updated to drive the ⧉N badge (`blast-badge`) instead of the old toggle line; after purge-everywhere the badge disappears (otherCount → 0). app typecheck clean. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
graydawnc
force-pushed
the
polish/security-blast-inline-badge
branch
from
c19a4dd to
55286b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two consistency passes on the Security finding rows:
CircleSlashacross every surface:CheckforCircleSlash.⊘ ◇).Checkstays only on genuine "resolved" status badges.Why
CircleSlash, already used by the meta-row Ignored entry) makes the action read consistently and matches the icon-only Purge.How it connects
BlastRadiusis now controlled: it reports the other-session count up (drives the badge) and renders the list only whenexpanded. SecurityPage ownsblastExpanded/blastCountand renders the badge in the value cell (clear of the right-edge hover-action cluster).data-testid+ scope menu, so behaviour is unchanged — only the trigger's chrome.Test plan
security-blast-radiuse2e updated to drive the ⧉N badge (blast-badge) instead of the removed toggle line; asserts the badge'sdata-sessions, expand → 1 session row + source dot, and that the badge disappears after purge-everywhere (otherCount → 0).security-findings-actionsgreen — per-row + bulk Dismiss/Purge and the Dismiss-all → meta-row refresh regression still pass with the icon-only trigger + CircleSlash menu.security-ignored-entrygreen. app typecheck clean; full app unit suite (329) green.🤖 Generated with Claude Code