✨ feat: Adds RFD tag for github contrib#29
Conversation
|
| Filename | Overview |
|---|---|
| ghcontrib/pr.go | Adds "✏️ RFD: " to validPRPrefixes; missing colon-based derivative (:pencil2: RFD: ) that all other prefix types provide. |
| ghcontrib/README.md | Documents the new ✏️ RFD: prefix, consistent with the code change. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[PR Title] --> B{HasPrefix check}
B -->|"✨ feat: "| V[✅ Valid]
B -->|"🔧 fix: "| V
B -->|"🧹 chore: "| V
B -->|"♻️ refactor: "| V
B -->|"🎨 design: "| V
B -->|"📚 docs: "| V
B -->|"✏️ RFD: " ✨NEW| V
B -->|":sparkles: feat: "| V
B -->|":wrench: fix: "| V
B -->|":broom: chore: "| V
B -->|":recycle: refactor: "| V
B -->|":art: design: "| V
B -->|":books: docs: "| V
B -->|":pencil2: RFD: " ❌MISSING| X[❌ Invalid - no match]
B -->|no match| X
Comments Outside Diff (1)
-
ghcontrib/pr.go, line 22-28 (link)Every other prefix type has a colon-based emoji derivative (e.g.
":sparkles: feat: "alongside"✨ feat: "). The new RFD prefix is missing its colon counterpart — a PR titled:pencil2: RFD: ...will fail validation even though the same convention works for all other types.Prompt To Fix With AI
This is a comment left during a code review. Path: ghcontrib/pr.go Line: 22-28 Comment: Every other prefix type has a colon-based emoji derivative (e.g. `":sparkles: feat: "` alongside `"✨ feat: "`). The new RFD prefix is missing its colon counterpart — a PR titled `:pencil2: RFD: ...` will fail validation even though the same convention works for all other types. How can I resolve this? If you propose a fix, please make it concise.
Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
ghcontrib/pr.go:22-28
Every other prefix type has a colon-based emoji derivative (e.g. `":sparkles: feat: "` alongside `"✨ feat: "`). The new RFD prefix is missing its colon counterpart — a PR titled `:pencil2: RFD: ...` will fail validation even though the same convention works for all other types.
```suggestion
// Colon based emoji derivatives
":sparkles: feat: ",
":wrench: fix: ",
":broom: chore: ",
":recycle: refactor: ",
":art: design: ",
":books: docs: ",
":pencil2: RFD: ",
```
Reviews (1): Last reviewed commit: "✨ feat: Adds RFD tag for github contrib" | Re-trigger Greptile
Signed-off-by: John McBride <john@papercompute.com>
For a
✏️ RFD:github PR. Related to: https://github.com/papercomputeco/engineering/pull/7Refs PCC-516