feat(web): web UI v1 — list, search, tag management#37
Open
paperhurts wants to merge 19 commits into
Open
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Restores <Navigate to="/setup" replace /> in RequireSettings (spec-compliant URL sync). Tests are refactored to use MemoryRouter + Routes instead of the data router (RouterProvider), bypassing the Node 24 undici/jsdom AbortSignal incompatibility that caused the data router's async navigate() to throw and leave the DOM empty. RequireSettings is now exported for test reuse. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…export, tighten AbortSignal filter
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Wires up ListPage with SearchBar and TagFilter components; adds memoized client in RequireSettings for stable useEffect deps; routing test updated to use inline placeholder elements. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Adds TagManager component with inline rename/color/delete per tag and a new-tag row; validation errors surface inline without calling onMutate. Wires TagsPage to use TagManager via useGitmarksData.writeTags. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Add packages/web/README.md with dev/build/smoke-test/architecture sections. Mark Web UI v1 complete in root README roadmap, append @gitmarks/web to the packages table, update the architecture diagram. Update CLAUDE.md package list and roadmap to reflect shipped status. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@gitmarks/webpackage — Vite + React 18 + Tailwind 3 SPA, deploys to GitHub Pages or Cloudflare Pages.tags.jsononly.localStoragepersistence. Hash routing (#/setup,#/,#/tags).@gitmarks/core'sGitHubClientwith ETag conditional refresh and 409 retry-replay for writes.spec.md.Closes #24.
Test plan
@gitmarks/web(Vitest + jsdom + @testing-library/react)pnpm typecheckclean,pnpm buildbuilds all 5 packagespackages/web/README.mdagainst a real bookmarks repopackages/web/dist/to GitHub Pages and verify hash routing works under a subpathImplementation notes
docs/superpowers/plans/2026-05-24-gitmarks-web-ui-v1.md(13 tasks, executed subagent-driven with per-task two-stage review).MemoryRouter + Routes/Routerather than the productioncreateHashRouterto sidestep a Node 24 / undici / jsdomAbortSignalinstance-check incompatibility. Production wiring uses the realcreateHashRouter+<Navigate>redirect; the test indirection is documented inline inApp.tsxandtest/setup.ts.useGitmarksDataseeds an empty file on 404 for bothbookmarks.jsonandtags.jsonso freshly-set-up users see the empty state, not a red error pill.🤖 Generated with Claude Code