Add codespell support (config, workflow to detect/not fix) and make it fix some typos #1071
Conversation
…(but ignoring overall fail due to ambigous ones)
=== Do not change lines below ===
{
"chain": [],
"cmd": "codespell -w || :",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "."
}
^^^ Do not change lines above ^^^
…nteractively
=== Do not change lines below ===
{
"chain": [],
"cmd": "codespell -w -i 3 -C 4",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "."
}
^^^ Do not change lines above ^^^
|
|
||
| const threshold = 300; | ||
| dy = Math.min(threshold, Math.abs(clone.y - this.initialY)); | ||
| dy = Math.min(threshold, Math.abs(clone.y - this.initially)); |
There was a problem hiding this comment.
This one is wrong. Can it be smarter about camelCase and/or only linting comments?
There was a problem hiding this comment.
oh, missed that. We can add regex to exclude all camelCases, e.g. `\b[a-z][A-Za-z]+\b' (Python regex), do you want me to do that? or we could exclude some specific ones like this to minimize possible false negatives.
There was a problem hiding this comment.
I think initalY is not very well readable, and if there is no strong reason to keep it that way, I would suggest renaming the variable.
|
should I rebase into PS FWIW, in some projects we eventually switched everywhere default branches to be the ones to seek PRs into to avoid hassle of needing to ask to rebase etc. Should may be |
|
Yes, all PRs should go to I wasn't involved with the decision to set up the branches how they are now (See CONTRIBUTING.md for history (it's short)). But We could probably do a better job of handling the install process (I'd guide people to use the |
3 participants
More about codespell: https://github.com/codespell-project/codespell .
I personally introduced it to dozens if not hundreds of projects already and so far only positive feedback.
CI workflow has 'permissions' set only to 'read' so also should be safe.