[agc] Reset transparent Chowdren effect-layer fills - #83
Merged
Conversation
Treat the exact untextured transparent-black premultiplied fill used by Chowdren as an overwrite. This prevents Dreaming Sarah fog and vignette render targets from accumulating across frames; SHARPEMU_DISABLE_TRANSPARENT_FILL_CLEAR=1 restores prior behavior.
There was a problem hiding this comment.
Pull request overview
This PR updates the AGC draw translation path to recognize a specific Chowdren “transparent black premultiplied fill” pattern as an effect-layer reset, preventing render-target accumulation across frames (notably for Dreaming Sarah fog/vignette). It also adds an opt-out environment variable to restore prior behavior.
Changes:
- Wraps the computed
VulkanGuestRenderStatewith a new heuristic (ApplyTransparentPremultipliedFillClear) before creatingTranslatedGuestDraw. - Detects the “untextured + no vertex inputs + transparent RGBA + premultiplied One/OneMinusSrcAlpha” draw shape and disables blending to force an overwrite.
- Adds
SHARPEMU_DISABLE_TRANSPARENT_FILL_CLEAR=1to disable this behavior.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SHARPEMU_DISABLE_TRANSPARENT_FILL_CLEAR=1to restore the previous behaviorScope
This is the minimal rendering portion of the earlier Dreaming Sarah investigation: 51 additions and one call-site change in
AgcExports.cs. It deliberately excludes the unrelated guest-image synchronization and diagnostics work.Validation
$HOME/.dotnet/dotnet build SharpEmu.slnx --no-restore