Skip to content

Conversation

@Ayushdubey86
Copy link
Contributor

Hello @mattsse , do check out this pr , once free!

Description
This PR addresses issue #15154 by explicitly notifying the payload build job when it's resolving, preventing unnecessary racing against empty blocks.

Changes:
Introduced an atomic boolean flag (is_resolving) within BasicPayloadJob and BuildArguments to indicate resolution status.
Set this flag explicitly when the payload resolution begins in resolve_kind.
Updated payload transaction-building loop to regularly check the is_resolving flag and exit immediately when resolution starts.

Resolves #15154

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this a good start so far,

still a few more things to update, see failing ci, but this is going in the right direction

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Reth Tracker Mar 20, 2025
@mattsse mattsse added the A-block-building Related to block building label Mar 20, 2025
@Ayushdubey86 Ayushdubey86 requested a review from gakonst as a code owner March 20, 2025 14:45
@Ayushdubey86 Ayushdubey86 requested a review from fgimenez as a code owner March 20, 2025 14:52
@Ayushdubey86 Ayushdubey86 requested a review from onbjerg as a code owner March 20, 2025 14:55
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 20, 2025

CodSpeed Performance Report

Merging #15170 will not alter performance

Comparing Ayushdubey86:Let-the-payloadjob-know-it-is-being-resolved-#15154 (5edf255) with main (5b06daa)

Summary

✅ 77 untouched benchmarks

@Ayushdubey86 Ayushdubey86 requested a review from mattsse March 20, 2025 16:17
@github-actions github-actions bot added S-stale This issue/PR is stale and will close with no further activity and removed S-stale This issue/PR is stale and will close with no further activity labels Apr 13, 2025
@Ayushdubey86
Copy link
Contributor Author

Ayushdubey86 commented Apr 16, 2025

Hey @mattsse @emhane , can we merge this pr? it has been open for some time now

@Ayushdubey86 Ayushdubey86 deleted the Let-the-payloadjob-know-it-is-being-resolved-#15154 branch April 23, 2025 20:11
@github-project-automation github-project-automation bot moved this from In Progress to Done in Reth Tracker Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-block-building Related to block building

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Let the payloadjob know it is being resolved

2 participants