-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Notify payload job explicitly when resolving (#15154) #15170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Ayushdubey86
wants to merge
20
commits into
paradigmxyz:main
from
Ayushdubey86:Let-the-payloadjob-know-it-is-being-resolved-#15154
Closed
Notify payload job explicitly when resolving (#15154) #15170
Ayushdubey86
wants to merge
20
commits into
paradigmxyz:main
from
Ayushdubey86:Let-the-payloadjob-know-it-is-being-resolved-#15154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested changes
Mar 20, 2025
Collaborator
mattsse
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this a good start so far,
still a few more things to update, see failing ci, but this is going in the right direction
CodSpeed Performance ReportMerging #15170 will not alter performanceComparing Summary
|
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @mattsse , do check out this pr , once free!
Description
This PR addresses issue #15154 by explicitly notifying the payload build job when it's resolving, preventing unnecessary racing against empty blocks.
Changes:
Introduced an atomic boolean flag (is_resolving) within BasicPayloadJob and BuildArguments to indicate resolution status.
Set this flag explicitly when the payload resolution begins in resolve_kind.
Updated payload transaction-building loop to regularly check the
is_resolving flagand exit immediately when resolution starts.Resolves #15154