Skip to content

DONOTMERGE: add trie node iter counting #15281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Rjected wants to merge 4 commits into from
Closed

DONOTMERGE: add trie node iter counting #15281

Rjected wants to merge 4 commits into from

Conversation

@Rjected
Copy link
Member

@Rjected Rjected commented Mar 25, 2025

just to demonstrate the number of seeks we do relative to the size of the proof we're returning

@Rjected Rjected force-pushed the dan/trie-node-iter-granular-counting branch from e8d9e76 to b48cd9f Compare March 25, 2025 23:01
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 25, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #15281 will not alter performance

Comparing dan/trie-node-iter-granular-counting (eeb7443) with main (1d1bfac)

Summary

✅ 77 untouched benchmarks

@emhane emhane added C-perf A change motivated by improving speed, memory usage or disk footprint A-observability Related to tracing, metrics, logs and other observability tools A-trie Related to Merkle Patricia Trie implementation labels Mar 26, 2025
@Rjected Rjected force-pushed the dan/trie-node-iter-granular-counting branch 3 times, most recently from 8e5beed to 647cd74 Compare March 27, 2025 19:07
@Rjected Rjected force-pushed the dan/trie-node-iter-granular-counting branch from 647cd74 to 4a0169a Compare March 27, 2025 19:22
@Rjected Rjected force-pushed the dan/trie-node-iter-granular-counting branch from eeb7443 to eee6e61 Compare March 31, 2025 21:20
@Rjected Rjected mentioned this pull request Mar 31, 2025
Closed
@Rjected
Copy link
Member Author

Rjected commented Apr 4, 2025

these are captured in metrics now

@Rjected Rjected closed this Apr 4, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Apr 4, 2025
@jenpaff jenpaff moved this from Done to Out of Scope in Reth Tracker Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin will be requested when the pull request is marked ready for review shekhirin is a code owner

@mediocregopher mediocregopher Awaiting requested review from mediocregopher mediocregopher will be requested when the pull request is marked ready for review mediocregopher is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse will be requested when the pull request is marked ready for review mattsse is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez will be requested when the pull request is marked ready for review fgimenez is a code owner

@yongkangc yongkangc Awaiting requested review from yongkangc yongkangc will be requested when the pull request is marked ready for review yongkangc is a code owner

Assignees

@Rjected Rjected

Labels

A-observability Related to tracing, metrics, logs and other observability tools A-trie Related to Merkle Patricia Trie implementation C-perf A change motivated by improving speed, memory usage or disk footprint

Projects

Reth Tracker
Status: Out of Scope

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Rjected @emhane @shekhirin