Skip to content

perf(trie): reduce hashed seeks in TrieNodeIter #15336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shekhirin merged 8 commits into from
Apr 2, 2025
Merged

perf(trie): reduce hashed seeks in TrieNodeIter #15336

shekhirin merged 8 commits into from
Apr 2, 2025

Conversation

@Rjected
Copy link
Member

@Rjected Rjected commented Mar 27, 2025 •
edited by shekhirin
Loading

@jenpaff jenpaff moved this from Todo to In Progress in Reth Tracker Mar 28, 2025
@emhane emhane added the A-trie Related to Merkle Patricia Trie implementation label Mar 31, 2025
@Rjected Rjected force-pushed the dan/less-hashed-seeks-pls-work branch 2 times, most recently from 190fbe0 to 00a55c5 Compare March 31, 2025 21:02
shekhirin
shekhirin reviewed Mar 31, 2025
View reviewed changes
@Rjected Rjected mentioned this pull request Mar 31, 2025
Closed
@jenpaff jenpaff marked this pull request as ready for review April 1, 2025 12:30
@jenpaff jenpaff requested a review from rkrasiuk as a code owner April 1, 2025 12:30
@shekhirin shekhirin changed the title wip: reduce hashed seeks in TrieNodeIter Reduce hashed seeks in TrieNodeIter Apr 1, 2025
@shekhirin shekhirin changed the title Reduce hashed seeks in TrieNodeIter perf(trie): reduce hashed seeks in TrieNodeIter Apr 1, 2025
@shekhirin shekhirin added the C-perf A change motivated by improving speed, memory usage or disk footprint label Apr 1, 2025
@shekhirin shekhirin changed the title perf(trie): reduce hashed seeks in TrieNodeIter perf(trie): reduce hashed seeks in TrieNodeIter Apr 1, 2025
@shekhirin shekhirin force-pushed the dan/less-hashed-seeks-pls-work branch from 557728d to 2ab46a1 Compare April 1, 2025 12:53
@jenpaff jenpaff moved this from In Progress to In Review in Reth Tracker Apr 1, 2025
@shekhirin
Copy link
Collaborator

shekhirin commented Apr 1, 2025

TODO: run with bigger multiproof chunk size

@Rjected Rjected force-pushed the dan/less-hashed-seeks-pls-work branch from 2ab46a1 to cc9a6dd Compare April 1, 2025 19:07
rkrasiuk
rkrasiuk approved these changes Apr 2, 2025
View reviewed changes
Copy link
Member

@rkrasiuk rkrasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nothing rings a bell, change seems ok

@github-project-automation github-project-automation bot moved this from In Review to In Progress in Reth Tracker Apr 2, 2025
@shekhirin shekhirin added this pull request to the merge queue Apr 2, 2025
Merged via the queue into main with commit 40015a8 Apr 2, 2025
42 checks passed
@shekhirin shekhirin deleted the dan/less-hashed-seeks-pls-work branch April 2, 2025 09:18
@github-project-automation github-project-automation bot moved this from In Progress to Done in Reth Tracker Apr 2, 2025
@jenpaff jenpaff moved this from Done to Completed in Reth Tracker Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shekhirin shekhirin shekhirin left review comments

@rkrasiuk rkrasiuk rkrasiuk approved these changes

Assignees

@Rjected Rjected

Labels

A-trie Related to Merkle Patricia Trie implementation C-perf A change motivated by improving speed, memory usage or disk footprint

Projects

Reth Tracker
Status: Completed

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TrieNodeIter seeks hashed cursor to branch nodes that we know the hash masks for

5 participants

@Rjected @shekhirin @rkrasiuk @emhane