perf(rpc): reduce estimate gas trait bounds to EvmStateProvider #19746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a minimal EvmStateProvider instead of full StateProvider trait.
datnguyencse
requested review from
Rjected,
RomanHodulak and
mattsse
as code owners
mattsse
requested changes
Nov 14, 2025
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
makes sense, but have questions re what appear to be unrelated changes
Comment on lines
97
to
101
| let TxKind::Call(to) = tx_env.kind() | ||
| { | ||
| code.map(|code| code.is_empty()).unwrap_or(true) | ||
| match db.basic(to) { | ||
| Ok(Some(account)) => account.code_hash == KECCAK_EMPTY, | ||
| _ => true, |
Contributor
There was a problem hiding this comment.
When switching from the StateProvider trait to EvmStateProvider, we can no longer use the account_code function and can only use the basic or basic_account functions from the Database or EvmStateProvider traits.
| ) -> Result<U256, Self::Error> | ||
| where | ||
| DB: Database<Error = ProviderError>, | ||
| DB: Database<Error = ProviderError> + Debug, |
Collaborator
There was a problem hiding this comment.
this seems appropriate, but why is this necessary here?
can we undo?
Contributor
There was a problem hiding this comment.
Nice catch, let me undo. Because I switched to using revm’s Database trait without Debug, I’ll switch back to reth_revm.
Contributor
Author
There was a problem hiding this comment.
@mattsse In case you've missed this PR, it's ready again Sir.
mattsse
approved these changes
Nov 18, 2025
Comment on lines
97
to
101
| let TxKind::Call(to) = tx_env.kind() | ||
| { | ||
| code.map(|code| code.is_empty()).unwrap_or(true) | ||
| match db.basic(to) { | ||
| Ok(Some(account)) => account.code_hash == KECCAK_EMPTY, | ||
| _ => true, |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces
StateProviderwithEvmStateProvidertrait bound inestimate_gas_withsince the EVM only needs the minimal database interface, not the full state provider API with block lookups, proofs, etc. This reduces trait overhead and makes dependencies explicit.It also makes it easier to implement another state provider to feed
estimate_gas_with, which we need.