feat: modular flashblocks #20122
Draft
feat: modular flashblocks #20122
+720
−283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
progr simplify Update cache.rs Update cache.rs simplify trait simplify Update sequence.rs simplifies Update lib.rs Update service.rs Simplify simplify
fixes mods generic Update decoding.rs rpc fixes temp remove consensus
fix custom node tidy Update lib.rs Update worker.rs Update worker.rs
rezbera
force-pushed
the
rezbera/modular-flashblocks
branch
from
21a3276 to
536bebf
Compare
rezbera
force-pushed
the
rezbera/modular-flashblocks
branch
from
536bebf to
64b9548
Compare
mattsse
reviewed
Dec 4, 2025
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
this looks very promising already
Comment on lines
+39
to
+40
| where | ||
| F: serde::de::DeserializeOwned, |
Collaborator
There was a problem hiding this comment.
hmm, I think only the new fn needs this bound?
Comment on lines
+59
to
+64
| /// The base payload type containing block environment configuration. | ||
| type Base: FlashblockPayloadBase; | ||
| /// The diff type containing state changes. | ||
| type Diff: FlashblockDiff; | ||
| /// The signed transaction type for this chain. | ||
| type SignedTx: reth_primitives_traits::SignedTransaction; |
Collaborator
There was a problem hiding this comment.
I see, this assumes a general structure flashblocks have, which I think is okay
Comment on lines
+56
to
+64
| /// Extension trait for OP-specific RPC types that includes flashblock configuration. | ||
| pub trait OpRpcTypes: RpcTypes { | ||
| /// The flashblock payload type for this chain. | ||
| type Flashblock: FlashblockPayload; | ||
| } | ||
|
|
||
| impl OpRpcTypes for Optimism { | ||
| type Flashblock = OpFlashblockPayload; | ||
| } |
Collaborator
There was a problem hiding this comment.
defining this on the rpctypes also makes sense to me
| flashblocks_sequence.subscribe(), | ||
| )?; | ||
| ctx.components.task_executor().spawn(Box::pin(flashblock_client.run())); | ||
| todo!("Modularize FlashBlockConsensusClient?") |
Collaborator
There was a problem hiding this comment.
yeah maybe a general purpose implementation would be great, but unsure if feasible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODOs
closes #20014