feat(cli): parse URL path and display ETA in reth download
#21014
+44
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shekhirin
added
C-enhancement
shekhirin
changed the title
reth downloadreth download
DaniPopes
approved these changes
Jan 14, 2026
pepyakin
approved these changes
Jan 14, 2026
| let elapsed = self.started_at.elapsed(); | ||
| let eta = if self.downloaded > 0 { | ||
| let remaining = self.total_size.saturating_sub(self.downloaded); | ||
| let speed = self.downloaded as f64 / elapsed.as_secs_f64(); |
Collaborator
There was a problem hiding this comment.
is it guaranteed that as_secs will always be greater than 0.0?
Collaborator
Author
There was a problem hiding this comment.
ye, should be ok
| Duration::ZERO | ||
| } | ||
| } else { | ||
| Duration::ZERO |
Collaborator
There was a problem hiding this comment.
do I understand it right that if it does not really progress then the duration is going to be displayed as 0sec?
Collaborator
Author
There was a problem hiding this comment.
yep, we can also do ∞ but I think doesn't matter
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
yongkangc
approved these changes
Jan 14, 2026
pepyakin
pushed a commit
that referenced
this pull request
Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to pass a path that has query arguments in it but the file itself still has a valid extension. Additionally, displays an ETA.