addImage createDataURIFromElement/getImageDataFromElement canvas image format

[SmythConor]

Hello, I noticed something with the version 1.5.3 in addImage createDataURIFromElement where the format parameter is ignored if the nodeName is canvas. In 1.4.1 the format was set depending on this parameter.

Now in recent updates: #2374 the format parameter has been removed which removes the ability to define what format you'd like to specify for the data.

I am working on trying to get a reproducible code snippet but it's proving difficult as the use case is kind of hard to isolate. However I do think this regresses the behaviour from 1.4.1. What do you think?

[Uzlopak]

Well, what is the benefit?

[es11400]

@arasabbasi I think that if a thing that previously worked stops working, it should not be removed in later versions, I have the feeling that it has been omitted by mistake when updating from one version to another, or some commit has been lost or crushed. I had to go back to version 1.4.1, to be able to use jsPDF with images through URL.

Thanks for your work.

[Uzlopak]

@es11400

Well, That feature-removal was accidently removed. But I streamlined and refactored the the image-processing and it should work again.

My question was more what the benefit is to set the canvas as png or jpeg as it is for me no difference, but anyhow... I reactivated the feature... well i think I did... didnt tested it. See #2416

[es11400]

@arasabbasi You're right, I do not see difference either, I look at # 2416 and try. Thank you

[SmythConor]

I could show you a before and after on Monday when I get a chance but it does make a difference. As I said it's a probably a pretty unique use case so it may not be obvious how it matters.

[es11400]

@arasabbasi It does not work with a url, it returns the same error, with version 1.5.3, do I need to update something?

Add ScreenShoot, it is the same error as in the example

[SmythConor]

Re-opening in the interest of @es11400

I had applied a patch a few weeks ago to my copy of jspdf so I know it works for my use case.

[Uzlopak]

clone project locally
npm run-script build
npm start

open in browser http://localhost:8000

Do it again.

[es11400]

Thanks in local works well.
When will it be available to everyone? with yarn add jspdf does not work, when I deploy my project in production it stops working.

[Uzlopak]

@es11400
This Tuesday MrRio wrote me that today is the day (of release) and I responded, that I found a huge bug (pages lose orientation when starting with landscape mode) and that I want to fix that. Tbh, last release was kind of emberassing. So I want to have a good version this time.

But I am now kind of sure, that most of the bugs are fixed.

[Uzlopak]

As it is solved and I like to close issues ;)