s3 C block and toolbox cleanup and improvements #1024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <field name="NUM">500</field> | ||
| </block> | ||
| </value> | ||
| <field name="TIMESCALE">1000</field> |
Contributor
There was a problem hiding this comment.
Was changing the time scale from 1000 to 1 a deliberate decision? I'm hoping that this was brought about as part of moving to the new C library for Spin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Large rearrangement of the s3 C block menu/toolbox. Cleans up block definitions and begins removing some duplicates ahead of the SPIN -> C transition. More improvements and staging to come.