Cdn 156 refactor editor layout #1694
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update local repo
This includes: - remove inline SVGs and set them to be replaced by JS on page load, similar to how the text internationalization is set up - classes that replace some inline styles - simplified navigation and UI elements - removes inline javascript, especially "onclick" triggers, moving them to editor.js and blocklyc.js instead.
Clean and merge into develop branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR must be merged in conjunction with BlocklyProp-cdn PR # 159!
I'm surprised some of the CDN changes haven't blown up the demo site.
This aligns the current editor HTML to the current CDN. It includes the remainder of the fixes need to make the HTML valid, as well as the newest refactor to remove tables from the layout and to get the block menu to display correctly across multiple browsers.