fix: return an error if C_GetFunctionList couldn't be found#345
Merged
wiktor-k merged 3 commits intoparallaxsecond:mainfrom Jan 19, 2026
Merged
Conversation
Signed-off-by: Mischan Toosarani-Hausberger <mischan@abovevacant.com>
supervacuus
force-pushed
the
fix/error_on_missing_symbol
branch
from
843b005 to
46e0882
Compare
wiktor-k
previously approved these changes
Jan 19, 2026
Collaborator
wiktor-k
left a comment
wiktor-k
left a comment
There was a problem hiding this comment.
Looks very clean and straightforward 👌
Co-authored-by: Wiktor Kwapisiewicz <wiktor@metacode.biz> Signed-off-by: Mischan Toosarani-Hausberger <mischan@abovevacant.com>
wiktor-k
approved these changes
Jan 19, 2026
ximon18
added a commit
to NLnetLabs/kmip2pkcs11
that referenced
this pull request
Feb 16, 2026
…ryptoki#345 to avoid panicking on non-PKCS#11 module file as input. (fixes #19)
ximon18
added a commit
to NLnetLabs/kmip2pkcs11
that referenced
this pull request
Feb 16, 2026
* Upgrade to cryptoki 0.12.0 to take upstream fix parallaxsecond/rust-cryptoki#345 to avoid panicking on non-PKCS#11 module file as input. (fixes #19) * Fix failure to find SoftHSM when running the full test on Fedora 43.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a user provides an incorrect library during construction, the interface fallback on V2 would panic instead of returning an error: NLnetLabs/kmip2pkcs11#19
This PR
MissingSymbol), andC_GetFunctionList, actually exists inpkcs11_libbefore calling it