ci: run examples on SoftHSM#355
Merged
keldonin merged 1 commit intoparallaxsecond:mainfrom Feb 5, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR enables automated execution of all examples during CI checks on SoftHSM, ensuring examples remain functional as the codebase evolves. The changes standardize test credentials across examples and tests, and establish guidelines for writing new examples.
Changes:
- Updated example PINs to match test credentials (
fedcba123456andabcdef654321) - Added CI workflow step to run all examples during SoftHSM tests
- Created README.md with guidelines for writing CI-compatible examples
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| cryptoki/examples/README.md | New documentation establishing rules and best practices for writing examples that run in CI |
| cryptoki/examples/generate_key_pair.rs | Updated PINs from short versions to standard test credentials and changed visibility to pub static for consistency |
| cryptoki/examples/thread_local_session.rs | Updated PINs to match test credentials and changed from const to pub static |
| .github/workflows/ci.yml | Added environment variables at job level and new step to run all examples sequentially |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wiktor-k
approved these changes
Feb 5, 2026
Collaborator
wiktor-k
left a comment
wiktor-k
left a comment
There was a problem hiding this comment.
LGTM 👌 excellent idea!
…xamples Signed-off-by: Eric Devolder <eric.devolder@gmail.com>
keldonin
force-pushed
the
ci_check_examples
branch
from
bb4d1c5 to
80dbb35
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the execution of all examples when performing checks.