fix(skills): move context references to parent skill resources#155
Merged
janhesters merged 4 commits intomainfrom Mar 18, 2026
Merged
fix(skills): move context references to parent skill resources#155janhesters merged 4 commits intomainfrom
janhesters merged 4 commits intomainfrom
Conversation
…ources Redux example, timing-safe vulnerabilities, and review example were incorrectly converted to standalone skills during the rules-to-skills migration. They are reference documentation, not actionable skills. - Move aidd-redux-example → aidd-autodux/references/redux-example.md - Move aidd-timing-safe-vulnerabilities → aidd-timing-safe-compare/references/vulnerabilities.md - Move review-example.md → aidd-review/references/review-example.md - Move user-testing.test.js → aidd-user-testing/user-testing.test.js - Remove empty ai/rules/ directory - Update all cross-references and index files - Strip skill frontmatter from reference files Closes #152, closes #153
Collaborator
|
@cursoragent please /review |
Contributor
|
Taking a look!   |
Collaborator
|
@cursoragent please /aidd-review |
Contributor
|
I've already completed a comprehensive code review following the AIDD review process. Here are the key findings: 🔬 Code Review SummaryOverall Assessment: ✅ APPROVE WITH ONE REQUIRED FIXScore: 8.7/10 overall This is a well-executed refactoring with clean commits, comprehensive cross-reference updates, and all 393 tests passing. Security review (OWASP Top 10) shows no vulnerabilities. ❌ Critical Issue (Must Fix Before Merge)File: Problem: Stale references to old file structure that no longer exists Current (broken): - [Product Management](../ai/rules/productmanager.mdc)
- [User Story Mapping](../ai/rules/productmanager.mdc)
- [Functional Requirements](../ai/rules/requirements.mdc)
- [Test Driven Development](../ai/rules/tdd.mdc)
- [SudoLang Syntax and Best Practices](../ai/rules/sudolang/)Required fix: - [Product Management](../ai/skills/aidd-product-manager/SKILL.md)
- [User Story Mapping](../ai/skills/aidd-product-manager/SKILL.md)
- [Functional Requirements](../ai/skills/aidd-functional-requirements/SKILL.md)
- [Test Driven Development](../ai/skills/aidd-tdd/SKILL.md)
- [SudoLang Syntax and Best Practices](../ai/skills/aidd-sudolang-syntax/SKILL.md)✅ Strengths
📊 Detailed Scores
🎯 Action Required
Risk Level: LOW (structural changes only) |
Co-authored-by: Eric Elliott <support@paralleldrive.com>
Update broken links that still pointed to the old ai/rules/ paths to use the new ai/skills/ structure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aidd-redux-examplefrom standalone skill toaidd-autodux/references/redux-example.md(closes Redux example should be context for autodux skill #153)aidd-timing-safe-vulnerabilitiesfrom standalone skill toaidd-timing-safe-compare/references/vulnerabilities.md(closes Timing safe compare vulnerabilities should be docs #152)ai/rules/review-example.mdtoaidd-review/references/review-example.mdai/rules/user-testing.test.jstoaidd-user-testing/user-testing.test.jsai/rules/directoryTest plan
user-testing.test.jspasses with updated pathsCode Review Findings
❌ One Required Fix Before Merge
Issue:
docs/learn-aidd-framework.md(newly added) contains stale references to old pathsLines 7-10, 24 reference non-existent paths:
ai/rules/productmanager.mdc→ should beai/skills/aidd-product-manager/SKILL.mdai/rules/requirements.mdc→ should beai/skills/aidd-functional-requirements/SKILL.mdai/rules/tdd.mdc→ should beai/skills/aidd-tdd/SKILL.mdai/rules/sudolang/→ should beai/skills/aidd-sudolang-syntax/SKILL.mdImpact: Broken documentation links for users learning the framework
✅ Review Summary
Overall Recommendation: APPROVE WITH ONE REQUIRED FIX
Full review details available in PR comments.