feat: add husky pre-commit hook for automated validation #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add Husky dependency for git hooks - Configure pre-commit hook to run tests and linting - Update package.json scripts for automatic lint fixing - Add prepare script for Husky initialization
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds Husky for automated pre-commit validation to ensure code quality before commits are made to the repository.
- Configure Husky as a development dependency with pre-commit hooks
- Update lint script to automatically fix issues instead of just reporting them
- Add prepare script for automatic Husky initialization
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Add Husky dependency, update lint script to auto-fix, and add prepare script |
| .husky/pre-commit | Create pre-commit hook that runs tests and linting |
| lib/release-process-e2e.test.js | Fix trailing comma formatting issues |
| ai/rules/please.mdc | Add constraint about API documentation verification |
| ai/rules/log.mdc | Remove "epic" from log descriptions |
| ai/rules/commit.mdc | Use activity log descriptions for commit planning |
| activity-log.md | Update log entries and add Husky implementation entry |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
13
to
+15
| "format": "prettier --write . && echo 'Format complete.'", | ||
| "format:check": "prettier --check . && echo 'Format check complete.'", | ||
| "test": "vitest run && echo 'Test complete.' && npm run -s lint" | ||
| "test": "vitest run && echo 'Test complete.' && npm run -s lint", |
There was a problem hiding this comment.
The test script runs linting with auto-fix, which could modify files during testing. This might cause confusion during CI/CD or when developers expect tests to only validate code without making changes. Consider using a lint check instead of auto-fix in the test pipeline.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Husky dependency for git hooks
Configure pre-commit hook to run tests and linting
Update package.json scripts for automatic lint fixing
Add prepare script for Husky initialization