Skip to content

Conversation

@ericelliott
Copy link
Collaborator

@ericelliott ericelliott commented Nov 7, 2025

  • Remove non-existent root export from package.json

  • Add './asyncPipe' subpath export with TypeScript definitions

  • Create lib/asyncPipe.d.ts with proper function signatures

  • Install TypeScript and add typecheck npm script

  • Add automated tests verifying import paths (lib/exports.test.js)

  • Update docs/server/README.md to use 'aidd/asyncPipe' import path

  • Archive completed library-exports-epic task


Note

Introduce tree-shakeable aidd/asyncPipe export with TS typings; update docs, add tests, and set up type checking.

  • Exports:
    • Add ./asyncPipe subpath in package.json with types (lib/asyncPipe.d.ts) and default (lib/asyncPipe.js).
    • Remove root export and add types mapping for ./server.
  • Type Definitions & Tooling:
    • Add lib/asyncPipe.d.ts with overloads.
    • Add typescript dev dependency, typecheck npm script, and tsconfig.json for type-only checks.
  • Tests:
    • Add lib/exports.test.js to verify aidd/asyncPipe import, function composition, aidd/server exports, and package.json exports config.
  • Docs:
    • Update docs/server/README.md to import asyncPipe from aidd/asyncPipe.
  • Project Tasks:
    • Mark library exports epic as completed (tasks/archive/library-exports-epic.md).

Written by Cursor Bugbot for commit e7a5680. This will update automatically on new commits. Configure here.

- Remove non-existent root export from package.json

- Add './asyncPipe' subpath export with TypeScript definitions

- Create lib/asyncPipe.d.ts with proper function signatures

- Install TypeScript and add typecheck npm script

- Add automated tests verifying import paths (lib/exports.test.js)

- Update docs/server/README.md to use 'aidd/asyncPipe' import path

- Archive completed library-exports-epic task
Copilot AI review requested due to automatic review settings November 7, 2025 01:32
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements tree-shakeable exports for the aidd package by removing the non-existent root export and adding explicit subpath exports with TypeScript support.

Key changes:

  • Removed the non-existent root "." export and added explicit ./asyncPipe and ./server subpath exports with TypeScript definitions
  • Added TypeScript tooling (typescript@5.9.3, tsconfig.json, and typecheck script) to validate type definitions
  • Created comprehensive automated tests to verify the new import paths work correctly

Reviewed Changes

Copilot reviewed 4 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
package.json Restructured exports to use explicit subpaths with TypeScript type definitions, added typescript devDependency and typecheck script
package-lock.json Added typescript@5.9.3 dependency
lib/asyncPipe.d.ts Created TypeScript definitions for asyncPipe utility with function overloads
lib/exports.test.js Added comprehensive tests verifying import paths and package.json exports configuration
tsconfig.json Created TypeScript configuration for type checking only (no emit)
docs/server/README.md Updated import examples from 'aidd' to 'aidd/asyncPipe'
tasks/archive/library-exports-epic.md Marked epic as completed and added implementation summary

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- Replace deprecated assert: { type: 'json' } with with: { type: 'json' }

- Updates to TC39 Stage 4 standard for import attributes
@ericelliott ericelliott merged commit 26e2dc1 into main Nov 7, 2025
4 checks passed
@ericelliott ericelliott deleted the fix-imports branch November 7, 2025 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants