Skip to content

Update load-functions.php#144

Closed
vuquangthinh wants to merge 1 commit intoparallelus:masterfrom
vuquangthinh:patch-1
Closed

Update load-functions.php#144
vuquangthinh wants to merge 1 commit intoparallelus:masterfrom
vuquangthinh:patch-1

Conversation

@vuquangthinh
Copy link
Copy Markdown

fix warning error

fix warning error
@kadimi
Copy link
Copy Markdown

kadimi commented Oct 22, 2015

+1, I got a notice and a warning just after enabling the theme Runway Framework on a site part of a WordPress network:

( ! ) Warning: Illegal string offset 'Icon' in /[...]/themes/Runway-Framework/runway-framework/framework/includes/load-functions.php on line 608

And:

( ! ) Notice: Uninitialized string offset: 0 in /[...]/themes/Runway-Framework/runway-framework/framework/includes/load-functions.php on line 608

@parallelus
Copy link
Copy Markdown
Owner

This was fixed in the core a while ago. If you are getting that error you need to download a newer version of Runway. Either the Master or Develop branch will have that patched.

Master branch: https://github.com/parallelus/Runway-Framework/archive/master.zip
Develop branch: https://github.com/parallelus/Runway-Framework/archive/develop.zip

@parallelus parallelus closed this Oct 23, 2015
@parallelus
Copy link
Copy Markdown
Owner

The version with your changes appears to already have the fix for this issue. We made the changes in the following commit back in May 2015: 0234945

It's possible this is another issue, however I'm currently using Runway on several network installs and not seeing the error message. If you can confirm that the latest version from the Develop branch doesn't fix this for you we can reopen the issue.

parallelus pushed a commit that referenced this pull request Oct 23, 2015
Warning: Illegal string offset 'Icon' in /framework/includes/load-functions.php on line 608
@parallelus
Copy link
Copy Markdown
Owner

I went ahead and applied similar code to the Develop branch and pushed it. The warning message posted by @kadimi would mean that this won't be fixed by our previous update and the added error checking can't do any harm.

@kadimi
Copy link
Copy Markdown

kadimi commented Oct 23, 2015

@parallelus

  • I later switched to a normal install and had the same errors
  • I tried develop, same errors

Thank you for applying the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants