Skip to content

Conversation

@cemde
Copy link
Collaborator

@cemde cemde commented Nov 21, 2025

  • added proper logging for LanggraphAgentAdapter and SmolAgentAdapter.

Description

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code quality improvement (refactoring, formatting, etc.)

Checklist

Contribution

Documentation

  • Added/updated docstrings for new/modified functions
  • Updated relevant documentation in docs/ (if applicable)
  • Tag github issue with this PR (if applicable)

Changelog

  • Added entry to CHANGELOG.md under [Unreleased] section
    • Use Added section for new features
    • Use Changed section for modifications to existing functionality
    • Use Fixed section for bug fixes
    • Use Removed section for deprecated/removed features
  • OR this is a documentation-only change (no changelog needed)

Example:
- Support for multi-agent tracing (PR:#123)

Architecture (if applicable)

  • Core/Interface separation: Changes in maseval/core/ do NOT import from maseval/interface/
  • Dependencies: New core dependencies added sparingly; framework integrations go to optional dependencies

Additional Notes

- added proper logging to smolagents
- updated testing for agents
- agent contract now testing for `logs` property.
@github-actions
Copy link

github-actions bot commented Nov 21, 2025

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  maseval/core
  agent.py
  maseval/interface/agents
  langgraph.py 174, 208-209, 218-229, 241
  smolagents.py 80, 134, 142, 149-150, 200
  maseval/interface/inference
  google_genai.py 44-50
Project Total  

This report was generated by python-coverage-comment-action

Copy link
Collaborator Author

@cemde cemde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@cemde cemde marked this pull request as ready for review November 23, 2025 11:56
@cemde cemde merged commit d196cdd into main Nov 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants