Skip to content

visualization: Add anatomy of icicle graphs and how to interpret them#254

Merged
kakkoyun merged 6 commits intomainfrom
iciclegraph_interpret
Mar 28, 2023
Merged

visualization: Add anatomy of icicle graphs and how to interpret them#254
kakkoyun merged 6 commits intomainfrom
iciclegraph_interpret

Conversation

@kakkoyun
Copy link
Copy Markdown
Contributor

@kakkoyun kakkoyun commented Mar 9, 2023

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
parca-docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 28, 2023 at 2:48PM (UTC)

@kakkoyun kakkoyun requested a review from brancz March 9, 2023 19:53
@kakkoyun kakkoyun force-pushed the iciclegraph_interpret branch from 7cc28e3 to 9efe4f4 Compare March 9, 2023 19:56
@kakkoyun kakkoyun force-pushed the iciclegraph_interpret branch from 9efe4f4 to 72deb66 Compare March 9, 2023 19:57
@kakkoyun kakkoyun force-pushed the iciclegraph_interpret branch from 72deb66 to 5efab3f Compare March 9, 2023 19:59
@kakkoyun kakkoyun force-pushed the iciclegraph_interpret branch from 5efab3f to 882cbdc Compare March 10, 2023 12:50
@kakkoyun kakkoyun force-pushed the iciclegraph_interpret branch from 7c7f0eb to af1242f Compare March 15, 2023 20:25
@kakkoyun kakkoyun force-pushed the iciclegraph_interpret branch from af1242f to e3d8057 Compare March 16, 2023 07:51
@kakkoyun kakkoyun force-pushed the iciclegraph_interpret branch from e3d8057 to 589c077 Compare March 16, 2023 09:48
@kakkoyun kakkoyun force-pushed the iciclegraph_interpret branch from 589c077 to 42df315 Compare March 16, 2023 10:23
@kakkoyun kakkoyun force-pushed the iciclegraph_interpret branch from 42df315 to 3ff2c5b Compare March 16, 2023 12:45
@kakkoyun kakkoyun force-pushed the iciclegraph_interpret branch from 52fcda3 to eef3b73 Compare March 16, 2023 18:14
Copy link
Copy Markdown
Contributor

@yomete yomete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very awesome additions to the docs Kemal! 👏🏾

Comment thread docs/icicle-graph-anatomy.mdx Outdated
@yomete
Copy link
Copy Markdown
Contributor

yomete commented Mar 23, 2023

One other thing, as this has happened about 2-3 times while I was checking this out locally. The documentation page Anatomy of icicle and flame graphs sometimes crashes after spending a period of time on it. This happens on Google Chrome for me. Curious to know if this happens to any other person.
Screenshot 2023-03-23 at 19 53 38

I imagine this could be because of the multiple animations on the page, and we can solve that by lazy loading those animations so that they're only loaded when they are visible in the browser window. Again, this could just me over exerting my computer's resources and its a non-issue.

@kakkoyun
Copy link
Copy Markdown
Contributor Author

One other thing, as this has happened about 2-3 times while I was checking this out locally. The documentation page Anatomy of icicle and flame graphs sometimes crashes after spending a period of time on it. This happens on Google Chrome for me. Curious to know if this happens to any other person. Screenshot 2023-03-23 at 19 53 38

I imagine this could be because of the multiple animations on the page, and we can solve that by lazy loading those animations so that they're only loaded when they are visible in the browser window. Again, this could just me over exerting my computer's resources and its a non-issue.

I've never encountered this. Thanks for letting me know. I'll try to figure out how to lazy load Rive animations.

@yomete
Copy link
Copy Markdown
Contributor

yomete commented Mar 27, 2023

One other thing, as this has happened about 2-3 times while I was checking this out locally. The documentation page Anatomy of icicle and flame graphs sometimes crashes after spending a period of time on it. This happens on Google Chrome for me. Curious to know if this happens to any other person. Screenshot 2023-03-23 at 19 53 38
I imagine this could be because of the multiple animations on the page, and we can solve that by lazy loading those animations so that they're only loaded when they are visible in the browser window. Again, this could just me over exerting my computer's resources and its a non-issue.

I've never encountered this. Thanks for letting me know. I'll try to figure out how to lazy load Rive animations.

Yeah, like i said, it could also just be my computer and it's a non-issue. Also happy to help with lazy loading the animations. Let me know if you'd like that.

Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Update walk-through

Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
@kakkoyun kakkoyun force-pushed the iciclegraph_interpret branch from eef3b73 to 72bce18 Compare March 27, 2023 19:42
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Co-authored-by: Yomi Eluwande <yomi.eluwande@gmail.com>
@kakkoyun kakkoyun merged commit 1854ff6 into main Mar 28, 2023
@kakkoyun kakkoyun deleted the iciclegraph_interpret branch March 28, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants