ui: Flachette eliminating array copy during the table parsing #6177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in the multiples of 8 in the frontend parsing
|
🔴 Meticulous spotted visual differences in 125 of 356 screens tested: view and approve differences detected. Meticulous evaluated ~4 hours of user flows against your PR. Last updated for commit 452ce1f. This comment will update as new commits are pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding padding to make sure the arrow buffer array byte offset falls in the multiples of 8 in the frontend parsing. This speeds up the table parsing to 1.3x compared to the apache-arrow lib.
Stacked to #6176