Conversation
|
✅ Meticulous spotted 0 visual differences across 378 screens tested: view results. Meticulous evaluated ~4 hours of user flows against your PR. Expected differences? Click here. Last updated for commit 5f623d1. This comment will update as new commits are pushed. |
brancz
approved these changes
Mar 10, 2026
When a dictionary transposition has zero entries (empty dictionary), accessing .Value(oldIndex) panics with 'index out of range [0] with length 0'. The .IsNull() check does not protect against this because the null bitmap is nil (meaning all values are considered non-null), so it returns false even when the array is empty. Add bounds checks (oldIndex >= indices.Len()) before accessing transposition indices in mergeSymbolizedRows and the key computation in generateFlamegraphArrowRecord. This matches the existing pattern already used in addSymbolizedRow which correctly guards with indices.Len() > 0.
thorfour
force-pushed
the
fix/flamegraph-empty-transposition-bounds-check
branch
from
af7b857 to
5f623d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a dictionary transposition has zero entries (empty dictionary), accessing .Value(oldIndex) panics with 'index out of range [0] with length 0'. The .IsNull() check does not protect against this because the null bitmap is nil (meaning all values are considered non-null), so it returns false even when the array is empty.
Add bounds checks (oldIndex >= indices.Len()) before accessing transposition indices in mergeSymbolizedRows and the key computation in generateFlamegraphArrowRecord. This matches the existing pattern already used in addSymbolizedRow which correctly guards with indices.Len() > 0.