*: Phase 1 of FrostDB removal — ClickHouse-only cmd path#6353
Open
thorfour wants to merge 2 commits into
Open
Conversation
Phase 1 of removing FrostDB. Collapses the dual-path init in pkg/parca/parca.go to ClickHouse-only and promotes the ClickHouse flags out of FlagsHidden so they're visible in --help. Removed flags: --storage-active-memory, --storage-enable-wal, --storage-snapshot-trigger-size, --storage-row-group-size, --storage-index-on-disk (FrostDB-only), the experimental --iceberg-storage hidden flag, and --clickhouse-enabled (the toggle is gone since ClickHouse is now the only backend). --enable-persistence survives but now controls only the local badger metastore — profile data lives in ClickHouse. The dynparquet/pqarrow imports are still load-bearing on the ClickHouse path (schema definition, normalizer, profilestore) — those go in a follow-up. pkg/ingester and pkg/parcacol/querier.go are dead from the cmd path now but tests still use them; they're removed when those tests get reworked against testcontainers. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
✅ Meticulous spotted 0 visual differences across 288 screens tested: view results. Meticulous evaluated ~4 hours of user flows against your PR. Expected differences? Click here. Last updated for commit |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 1 of removing FrostDB from Parca (tracking issue / Discord thread). Collapses the dual-path init in
pkg/parca/parca.goto ClickHouse-only and promotes the ClickHouse flags out ofFlagsHiddenso they're visible in--help.--storage-active-memory,--storage-enable-wal,--storage-snapshot-trigger-size,--storage-row-group-size,--storage-index-on-disk, the experimental--iceberg-storagehidden flag, and--clickhouse-enabled(the toggle is gone since ClickHouse is now the only backend).--enable-persistencesurvives but now controls only the local badger metastore — profile data lives in ClickHouse.pkg/ingester/andpkg/parcacol/querier.goare dead from the cmd path but kept in tree because the existing test suite still exercises them; they get removed when those tests are reworked against testcontainers (Phase 3).dynparquet/pqarrowimports are still load-bearing on the ClickHouse path (schema definition, normalizer, profilestore) — those are untangled in Phase 2.Benchmark_WriteRawis nowb.Skip'd since it droveRun()which now requires ClickHouse. Restored via testcontainers in Phase 3.snap/parca-wrapperno longer plumbs--storage-active-memory. Wiring full ClickHouse config (address/credentials) into the snap is a separate follow-up.README.mdregenerated viamake README.md.Follow-ups
dynparquet+pqarrowfrompkg/normalizer/,pkg/profile/schema.go,pkg/profilestore/profilecolumnstore.go,pkg/query/{flamegraph_arrow,table,columnquery}.go.pkg/parca/parca_test.go,pkg/profilestore/profilestore_test.go,pkg/ingester/ingester_test.go,pkg/query/{query,columnquery}_test.goagainst testcontainers ClickHouse; deletepkg/ingester/andpkg/parcacol/querier.go.go mod tidy; dropfrostdbandiceberg-gofromgo.mod.clickhouse-*snap config keys + hooks so the snap can boot a usable parca without command-line overrides.Test plan
go build ./...go vet ./...go test -short ./...parcaboots against a local ClickHouse and ingests a profileparca --helpreads cleanly (regenerated README)🤖 Generated with Claude Code